Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created search input component. #26

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Created search input component. #26

wants to merge 10 commits into from

Conversation

omarefg
Copy link

@omarefg omarefg commented Mar 30, 2020

DESCRIPTION

Added possibility to search for an article using its title from a search input.

INFORMATION

name: Omar Flores
username: https://platzi.com/@omarefg
coach: Cesar Pedraza
cohort: 1

PR TYPE

  • BlogPost
  • BugFix
  • Feature
  • Enhancement

@gndx gndx added the feature label Apr 1, 2020
@gndx
Copy link
Contributor

gndx commented Apr 1, 2020

Fix: Separar el footer y también manejar un mensaje de articulo no encontrado.

Screen Shot 2020-04-01 at 9 42 49 AM

@gndx
Copy link
Contributor

gndx commented Apr 1, 2020

Fix: Subir el buscador al mismo nivel del Logo y establecer un tamaño menor.

Screen Shot 2020-04-01 at 9 43 32 AM

gndx
gndx requested changes Apr 1, 2020
View reviewed changes
src/components/search.js Outdated Show resolved Hide resolved
src/components/search.js Show resolved Hide resolved
src/pages/index.js Outdated Show resolved Hide resolved
@omarefg omarefg requested a review from gndx April 12, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gndx gndx Awaiting requested review from gndx

Assignees

@omarefg omarefg

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omarefg @gndx