Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Nano cryptocurrency in V4V spec, adding documentation #303

Merged
merged 3 commits into from
Nov 17, 2021

Conversation

koczadly
Copy link
Contributor

This adds a Value 4 Value specification and associated constants for the Nano cryptocurrency.

If there's another procedure for registering and declaring a cryptocurrency in the V4V spec, please let me know and I'll be sure to do it.

@daveajones
Copy link
Contributor

Thanks for submitting this. Will review today. We might want to separate into various “appendix” type documents with references from the main to help people just clicking through the repo find it easier. Let me see how it feels/reads first.

@brianoflondon
Copy link
Contributor

Having written pretty much the same addition for Hive but which still isn't in the core spec I think we should definitely separate other examples from the main document.

Whether that's one document per currency or one appendix till it grows to big I don't know.

The reason Hive isn't there now, however, is because showing a spec without any realistic prospect of anyone working to implement it didn't seem very important and because I'm the main person driving any involvement of Hive and I've adapted to work within the Lightning eco-system for now, I'm not sure what good it does.

@zhyatt
Copy link

zhyatt commented Oct 13, 2021

... I'm not sure what good it does.

Thanks for your consideration on this. I am working with @koczadly on evaluating the possibility of Nano integrations using the podcast:value tag. From our perspective, the value of having the standard for Nano defined in the spec is to provide guidance to our community who often lead the building of tools and integrations like these. It would also give podcasters in our community details about setting up their RSS feed for this feature should it become supported in podcast apps.

Although we don't have a direct implementation in progress, Podverse.fm were the ones who brought this spec to our attention and indicated their interest in supporting Nano as a payment option, were it to be included in RSS feeds. If an existing implementation and usage is a pre-requisite for entry into the spec, let us know and we can broadcast this via other means until we reach that threshold.

@brianoflondon
Copy link
Contributor

There is one constraint and perhaps we do need to lift it: the current Value Block spec says only one type of value block per feed. I always thought it should be more but I backed down on that.

I'm happy to re-add my Hive suggestion too but I'm not in a position to drive adoption of it.

@dellagustin
Copy link
Contributor

There is one constraint and perhaps we do need to lift it: the current Value Block spec says only one type of value block per feed. I always thought it should be more but I backed down on that.

Related to that - #300

@dellagustin
Copy link
Contributor

dellagustin commented Oct 16, 2021

@koczadly any known podcasts that would adopt this once added to the spec?
Or even, is it already in use "in the wild"?
I would be interested to add support for it in podStation, after getting familiar with the tech.

@koczadly
Copy link
Contributor Author

any known podcasts that would adopt this once added to the spec

I'm not aware of any podcasts who intend to or already use Nano for donations, though given quite the large community I'd imagine this would quickly grow once it gains support within apps. As @zhyatt pointed out, right now we're just trying to lay the groundwork by officially declaring the standards/constants for integration with Value4Value apps.

I would be interested to add support for it in podStation

That's truly fantastic to hear that you're interested in supporting it! Right now we're still working on trying to ease the integration process. Currently the main difficulty with integrations is handing the funds — most podcasting apps (such as podStation) use LNPay's custodial service, and to the best of my knowledge there are no similar services for Nano. I'd be more than happy to help out and provide guidance if you decide to provide support for Nano.

@brianoflondon
Copy link
Contributor

If we change the spec to multiple crypto I will add a Hive Value block to more than 1000 value enabled podcast feeds. (All the 3speak feeds).

@dellagustin
Copy link
Contributor

Next year I'll be mostly busy rewriting good chunks of podStation to ensure I can survive the Manifest V3 of extensions for Google Chrome and yet be usable on other browsers.

Aside from that, I would like to support as many v4v modes we have out there, within reasonable effort.

I have already created feature requests for HIVE and Nano:

@daveajones
Copy link
Contributor

@zhyatt Could you resolve the conflicts or do a new PR on this one? I got behind in merging some other ones and it looks like it messed you up.

@koczadly
Copy link
Contributor Author

koczadly commented Nov 8, 2021

@daveajones I have resolved the conflicts.

The appendix section appears to be very lightning specific, and is a nested heading of the lightning section. In my commit I have kept the appendix together under the lightning heading, but this may be out of place?

I do think the document could perhaps do with some restructuring. For instance, the value override example is shown under the Supported currencies > Lightning heading, whereas it's more of a general example.

It may also be worth hiding the supported currencies section within <details> blocks (if they're still supported?), allowing the reader to expand only the relevant sections.

@daveajones daveajones merged commit 021d9ef into Podcastindex-org:main Nov 17, 2021
@daveajones
Copy link
Contributor

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants