Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix benchmarks #241

Closed
wants to merge 36 commits into from
Closed

🐛 Fix benchmarks #241

wants to merge 36 commits into from

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Apr 17, 2024

This PR is built on top of #229

What?

  • fix all benchmarks that errored out when running just dry-run-benchmarks

How?

  • Pallet funding required funding the ct treasury account with ed on the chain spec
  • Linear release required using config types in the benchmark code instead of hardcoded values

Testing?

  • Run just dry-run-benchmarks and see if no errors pops up

@JuaniRios JuaniRios self-assigned this Apr 17, 2024
@JuaniRios JuaniRios changed the title Fix funding benchmarks 🐛 Fix funding benchmarks Apr 17, 2024
@JuaniRios JuaniRios changed the title 🐛 Fix funding benchmarks 🐛 Fix benchmarks Apr 17, 2024
@JuaniRios JuaniRios closed this Apr 17, 2024
@JuaniRios JuaniRios deleted the fix-funding-benchmarks branch April 17, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant