chore: upgrade rrweb to alpha.17 #1489
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +76.7 kB (+2.55%) Total Size: 3.09 MB
ℹ️ View Unchanged
|
|
we were queueing #1464 on these upgrades but 🤔 |
|
i guess that this isn't working because postcss is already bundled in with rrweb, not being included by our bundler 🤔 |
|
tested locally and can still record and playback. the bundle size increase is pretty extreme but we can loop back and improve that once we have things fixed |
holy cow that increase is almost all in the console recorder 🤯 |
|
🤣 🤣 🤣 🤣 🤣 🤣 🤣 🤣 🤣 @daibhin search in the console recorder js for |
|
i believe bundle size fix is in rrweb-io/rrweb#1594 |
Crikey! We might need to contribute our bundle size increase checker back to rrweb 😅 I should really never have been allowed to increase the size of that package so much in the first place |
|
@pauldambra genius!! I removed the postcss code from the console plugin and the package sizes are finally back in a place of reasonable increase. Want to do a little bit of cleanup given all the changes we've made in this PR but ultimately think we're good to ship this upgrade |
rollup.config.js
Outdated
| // we know that recorder doesn't use postcss, but the bundler can't determine that | ||
| external: ['postcss'], |
There was a problem hiding this comment.
do we still need this? it didn't work, right?
| // we know that recorder doesn't use postcss, but the bundler can't determine that | |
| external: ['postcss'], |
| @@ -72,7 +71,7 @@ describe('MutationRateLimiter', () => { | |||
|
|
|||
| test('returns event if _any_ adds are left', () => { | |||
| const event = makeEvent({ | |||
| adds: [{ parentId: 0, nextId: 0, node: {} as unknown as serializedNodeWithId }], | |||
There was a problem hiding this comment.
Will have to come back and type this once rrweb-io/rrweb#1593 merges
Changes
Trying something out...
Checklist