Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(flags): Add specific timeout for feature flags #62

Merged
merged 2 commits into from
Mar 11, 2024
Merged

feat(flags): Add specific timeout for feature flags #62

merged 2 commits into from
Mar 11, 2024

Conversation

neilkakkar
Copy link
Contributor

and accompanying docs : PostHog/posthog.com#8015

benjackwhite
benjackwhite approved these changes Mar 8, 2024
View reviewed changes
Copy link

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woooohh php.

Mostly trusting the tests tbh

@neilkakkar
Copy link
Contributor Author

Been simulating a broken DB and testing manually with all the SDKs that timeouts work, so reasonably confident with these PRs 👍

@neilkakkar neilkakkar merged commit 291a124 into master Mar 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjackwhite benjackwhite benjackwhite approved these changes

@jurajmajerik jurajmajerik Awaiting requested review from jurajmajerik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neilkakkar @benjackwhite