Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the omnisharp group with 4 updates #2074

Closed
wants to merge 3 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 15, 2023

Bumps the omnisharp group with 4 updates: OmniSharp.Extensions.LanguageServer, OmniSharp.Extensions.DebugAdapter.Server, OmniSharp.Extensions.LanguageClient and OmniSharp.Extensions.DebugAdapter.Client.

Updates OmniSharp.Extensions.LanguageServer from 0.19.7 to 0.19.8

Release notes

Sourced from OmniSharp.Extensions.LanguageServer's releases.

v0.19.8

What's Changed

... (truncated)

Commits
  • b478739 Fix release draft action permissions
  • d76b8e3 Install the pinned dotnet SDK
  • dbd1178 Merge pull request #1019 from JoeRobich/update-3.17
  • 808d6be Merge branch 'master' into update-3.17
  • d8cc8dd Move to codecov-action v4 beta2
  • 16a8c1c Merge branch 'master' into update-3.17
  • bed3f73 Update codecov/codecov-action action to v4
  • 53a8f08 Update test snapshots
  • 348897d Apply remaining 3.17 updates.
  • 8258355 Update dependency dotnet-sdk to v6.0.414
  • Additional commits viewable in compare view

Updates OmniSharp.Extensions.DebugAdapter.Server from 0.19.7 to 0.19.8

Release notes

Sourced from OmniSharp.Extensions.DebugAdapter.Server's releases.

v0.19.8

What's Changed

... (truncated)

Commits
  • b478739 Fix release draft action permissions
  • d76b8e3 Install the pinned dotnet SDK
  • dbd1178 Merge pull request #1019 from JoeRobich/update-3.17
  • 808d6be Merge branch 'master' into update-3.17
  • d8cc8dd Move to codecov-action v4 beta2
  • 16a8c1c Merge branch 'master' into update-3.17
  • bed3f73 Update codecov/codecov-action action to v4
  • 53a8f08 Update test snapshots
  • 348897d Apply remaining 3.17 updates.
  • 8258355 Update dependency dotnet-sdk to v6.0.414
  • Additional commits viewable in compare view

Updates OmniSharp.Extensions.LanguageClient from 0.19.7 to 0.19.8

Release notes

Sourced from OmniSharp.Extensions.LanguageClient's releases.

v0.19.8

What's Changed

... (truncated)

Commits
  • b478739 Fix release draft action permissions
  • d76b8e3 Install the pinned dotnet SDK
  • dbd1178 Merge pull request #1019 from JoeRobich/update-3.17
  • 808d6be Merge branch 'master' into update-3.17
  • d8cc8dd Move to codecov-action v4 beta2
  • 16a8c1c Merge branch 'master' into update-3.17
  • bed3f73 Update codecov/codecov-action action to v4
  • 53a8f08 Update test snapshots
  • 348897d Apply remaining 3.17 updates.
  • 8258355 Update dependency dotnet-sdk to v6.0.414
  • Additional commits viewable in compare view

Updates OmniSharp.Extensions.DebugAdapter.Client from 0.19.7 to 0.19.8

Release notes

Sourced from OmniSharp.Extensions.DebugAdapter.Client's releases.

v0.19.8

What's Changed

... (truncated)

Commits
  • b478739 Fix release draft action permissions
  • d76b8e3 Install the pinned dotnet SDK
  • dbd1178 Merge pull request #1019 from JoeRobich/update-3.17
  • 808d6be Merge branch 'master' into update-3.17
  • d8cc8dd Move to codecov-action v4 beta2
  • 16a8c1c Merge branch 'master' into update-3.17
  • bed3f73 Update codecov/codecov-action action to v4
  • 53a8f08 Update test snapshots
  • 348897d Apply remaining 3.17 updates.
  • 8258355 Update dependency dotnet-sdk to v6.0.414
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the omnisharp group with 4 updates: [OmniSharp.Extensions.LanguageServer](https://github.com/OmniSharp/csharp-language-server-protocol), [OmniSharp.Extensions.DebugAdapter.Server](https://github.com/OmniSharp/csharp-language-server-protocol), [OmniSharp.Extensions.LanguageClient](https://github.com/OmniSharp/csharp-language-server-protocol) and [OmniSharp.Extensions.DebugAdapter.Client](https://github.com/OmniSharp/csharp-language-server-protocol).


Updates `OmniSharp.Extensions.LanguageServer` from 0.19.7 to 0.19.8
- [Release notes](https://github.com/OmniSharp/csharp-language-server-protocol/releases)
- [Changelog](https://github.com/OmniSharp/csharp-language-server-protocol/blob/master/GitReleaseManager.yaml)
- [Commits](OmniSharp/csharp-language-server-protocol@v0.19.7...v0.19.8)

Updates `OmniSharp.Extensions.DebugAdapter.Server` from 0.19.7 to 0.19.8
- [Release notes](https://github.com/OmniSharp/csharp-language-server-protocol/releases)
- [Changelog](https://github.com/OmniSharp/csharp-language-server-protocol/blob/master/GitReleaseManager.yaml)
- [Commits](OmniSharp/csharp-language-server-protocol@v0.19.7...v0.19.8)

Updates `OmniSharp.Extensions.LanguageClient` from 0.19.7 to 0.19.8
- [Release notes](https://github.com/OmniSharp/csharp-language-server-protocol/releases)
- [Changelog](https://github.com/OmniSharp/csharp-language-server-protocol/blob/master/GitReleaseManager.yaml)
- [Commits](OmniSharp/csharp-language-server-protocol@v0.19.7...v0.19.8)

Updates `OmniSharp.Extensions.DebugAdapter.Client` from 0.19.7 to 0.19.8
- [Release notes](https://github.com/OmniSharp/csharp-language-server-protocol/releases)
- [Changelog](https://github.com/OmniSharp/csharp-language-server-protocol/blob/master/GitReleaseManager.yaml)
- [Commits](OmniSharp/csharp-language-server-protocol@v0.19.7...v0.19.8)

---
updated-dependencies:
- dependency-name: OmniSharp.Extensions.LanguageServer
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: omnisharp
- dependency-name: OmniSharp.Extensions.DebugAdapter.Server
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: omnisharp
- dependency-name: OmniSharp.Extensions.LanguageClient
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: omnisharp
- dependency-name: OmniSharp.Extensions.DebugAdapter.Client
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: omnisharp
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team September 15, 2023 21:38
@dependabot dependabot bot added .NET labels Sep 15, 2023
By searching OmniSharp's diff for what changed, whee.
But it's throwing:

    [Error - 4:53:23 PM] OmniSharp.Extensions.JsonRpc.DefaultRequestInvoker: Failed to handle request initialize 0 - Newtonsoft.Json.JsonSerializationException: Error converting value True to type 'OmniSharp.Extensions.LanguageServer.Protocol.Supports`1[OmniSharp.Extensions.LanguageServer.Protocol.Client.Capabilities.SemanticTokensCapabilityRequestRange]'. Path 'textDocument.semanticTokens.requests.range', line 1, position 4679.
     ---> System.ArgumentException: Could not cast or convert from System.Boolean to OmniSharp.Extensions.LanguageServer.Protocol.Supports`1[OmniSharp.Extensions.LanguageServer.Protocol.Client.Capabilities.SemanticTokensCapabilityRequestRange].

The sample server still has this set to `true` and that should be valid,
but David has a conference demo that set it with this object. I don't
know. I can't find anything client-side to change.
@@ -25,7 +25,7 @@ protected override SemanticTokensRegistrationOptions CreateRegistrationOptions(S
{
Delta = true
},
Range = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-driscoll do you have any idea why the server is failing to initialize with that error? The type of Range here is BooleanOr<SemanticTokensCapabilityRequestRange> so it should be fine but I'm getting a serialization exception.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 18, 2023

The group that created this PR has been removed from your configuration.

@dependabot dependabot bot closed this Sep 18, 2023
@dependabot dependabot bot deleted the dependabot/nuget/omnisharp-3768db307b branch September 18, 2023 21:42
@andyleejordan andyleejordan mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant