Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in New-HelpCabinetFile from OPS13 #705

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

sdwheeler
Copy link
Collaborator

@sdwheeler sdwheeler commented Oct 26, 2024

Fix bugs in New-HelpCabinetFile from OPS13

  • Fixes AB#331105

Prior to this PR there were two bugs in New-HelpCabinetFile

  • If there was no existing HelpInfo.xml file it would fail to create a new one
  • The warning message about invalid help files in the folder didn't correctly include the filename of the invalid file

This PR fixes those issues and changes the CabinetFileFolder parameter name to HelpFileFolder to better reflect its purpose.

@sdwheeler sdwheeler changed the base branch from master to v2 October 26, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant