Skip to content

Commit

Permalink
refactor: Removes the CSS files from the Sunburst plugin (apache#19488)
Browse files Browse the repository at this point in the history
  • Loading branch information
michael-s-molina authored Apr 4, 2022
1 parent 4b92287 commit 4730802
Show file tree
Hide file tree
Showing 5 changed files with 83 additions and 112 deletions.
36 changes: 17 additions & 19 deletions superset-frontend/plugins/legacy-plugin-chart-sunburst/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,37 +2,35 @@
"name": "@superset-ui/legacy-plugin-chart-sunburst",
"version": "0.18.25",
"description": "Superset Legacy Chart - Sunburst",
"sideEffects": [
"*.css"
],
"main": "lib/index.js",
"module": "esm/index.js",
"files": [
"esm",
"lib"
],
"repository": {
"type": "git",
"url": "git+https://github.com/apache-superset/superset-ui.git"
},
"keywords": [
"superset"
],
"author": "Superset",
"license": "Apache-2.0",
"homepage": "https://github.com/apache-superset/superset-ui#readme",
"bugs": {
"url": "https://github.com/apache-superset/superset-ui/issues"
},
"homepage": "https://github.com/apache-superset/superset-ui#readme",
"publishConfig": {
"access": "public"
"repository": {
"type": "git",
"url": "git+https://github.com/apache-superset/superset-ui.git"
},
"license": "Apache-2.0",
"author": "Superset",
"main": "lib/index.js",
"module": "esm/index.js",
"files": [
"esm",
"lib"
],
"dependencies": {
"d3": "^3.5.17",
"prop-types": "^15.6.2"
},
"peerDependencies": {
"@superset-ui/chart-controls": "*",
"@superset-ui/core": "*"
"@superset-ui/core": "*",
"react": "^16.13.1"
},
"publishConfig": {
"access": "public"
}
}

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import React from 'react';
import { reactify, styled } from '@superset-ui/core';
import Component from './Sunburst';

const ReactComponent = reactify(Component);

const Sunburst = ({ className, ...otherProps }) => (
<div className={className}>
<ReactComponent {...otherProps} />
</div>
);

export default styled(Sunburst)`
${({ theme }) => `
.superset-legacy-chart-sunburst text {
text-rendering: optimizeLegibility;
}
.superset-legacy-chart-sunburst path {
stroke: ${theme.colors.grayscale.light2};
stroke-width: 0.5px;
}
.superset-legacy-chart-sunburst .center-label {
text-anchor: middle;
fill: ${theme.colors.grayscale.dark1};
pointer-events: none;
}
.superset-legacy-chart-sunburst .path-abs-percent {
font-size: ${theme.typography.sizes.m}px;
font-weight: ${theme.typography.weights.bold};
}
.superset-legacy-chart-sunburst .path-cond-percent {
font-size: ${theme.typography.sizes.s}px;
}
.superset-legacy-chart-sunburst .path-metrics {
color: ${theme.colors.grayscale.base};
}
.superset-legacy-chart-sunburst .path-ratio {
color: ${theme.colors.grayscale.base};
}
.superset-legacy-chart-sunburst .breadcrumbs text {
font-weight: ${theme.typography.weights.bold};
font-size: ${theme.typography.sizes.m}px;
text-anchor: middle;
fill: ${theme.colors.grayscale.dark1};
}
`}
`;

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import {
getSequentialSchemeRegistry,
} from '@superset-ui/core';
import wrapSvgText from './utils/wrapSvgText';
import './Sunburst.css';

const propTypes = {
// Each row is an array of [hierarchy-lvl1, hierarchy-lvl2, metric1, metric2]
Expand Down

0 comments on commit 4730802

Please sign in to comment.