Feature: PContextMenu
#1154
Merged
Feature: PContextMenu
#1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znicholasbrown
requested review from
pleek91,
zhen0 and
brandonreid
as code owners
✅ Deploy Preview for prefect-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Ah we've got a demo that's bulk importing everything from the positions utility file... hmm I'll have to filter these out somehow |
pleek91
reviewed
Mar 15, 2024
pleek91
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a more generic and extended version of
PIconButtonMenu. It exposes slots fortargetandcontext-menu(overrides the defaultPOverflowMenufor maximum customization). Thedefaultre-exposes thedefaultslot ofPOverflowMenu.Some more interesting enhancements are the addition of behavior to open the context menu at position of the mouse. This should be helpful when creating true context menus (e.g. overriding the browser right-click behavior) or when position around the target container isn't quite the right behavior.
Check out the demo for some working samples of both