Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fixed VPC Connector usage in Cloud Run Worker v2 #252

Merged

Conversation

japerry911
Copy link
Contributor

Closes
#251

Example

Screenshots

  • VPC Connector Name in action in Cloud Run
    Screenshot 2024-03-01 at 10 28 00 AM

  • VPC Connector Name being declared in Prefect Advanced Config Job Options (can also be declared in the normal configuration selection menu)
    Screenshot 2024-03-01 at 10 28 19 AM

  • VPC Connector Name left blank shows None in Cloud Run and runs successfully
    Screenshot 2024-03-01 at 12 17 00 PM

Checklist

  • References any related issue by including "Closes #" or "Closes ".
    • If no issue exists and your change is not a small fix, please create an issue first.
  • Includes tests or only affects documentation.
  • Passes pre-commit checks.
    • Run pre-commit install && pre-commit run --all locally for formatting and linting.
  • Includes screenshots of documentation updates.
    • Run mkdocs serve view documentation locally.
    • n/a

@japerry911 japerry911 requested a review from a team as a code owner March 1, 2024 19:27
Copy link
Contributor

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me! thank you @japerry911 🌟

@zzstoatzz zzstoatzz merged commit f742dd4 into PrefectHQ:main Mar 5, 2024
10 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants