Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopt async_dispatch for slack collection #15973

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Nov 11, 2024

related to #15008

first of many PRs to define explicit sync / async interfaces where we previously had @sync_compatible

In [1]: from prefect_slack import SlackWebhook

In [2]: s = SlackWebhook(url="https://hooks.slack.com/services/xxx/xxx/xxx")

# all of the below work

In [3]: s.notify("oi")

In [4]: await s.notify_async("oi")

In [5]: await s.notify("oi")

@zzstoatzz zzstoatzz added integrations Related to integrations with other services development Tech debt, refactors, CI, tests, and other related work. labels Nov 11, 2024
@zzstoatzz zzstoatzz marked this pull request as ready for review November 11, 2024 16:28
@zzstoatzz zzstoatzz self-assigned this Nov 11, 2024
@zzstoatzz zzstoatzz merged commit 730320d into main Nov 11, 2024
15 checks passed
@zzstoatzz zzstoatzz deleted the first-async-dispatch branch November 11, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Tech debt, refactors, CI, tests, and other related work. integrations Related to integrations with other services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants