migrate prefect_aws.batch off sync_compatible
#16053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #16053 will not alter performanceComparing Summary
|
zzstoatzz
added
integrations
zzstoatzz
commented
Nov 19, 2024
Comment on lines
87
to
128
| assert_valid_job_id(job_id) | ||
|
|
||
|
|
||
| async def test_batch_submit_async_dispatch( | ||
| job_queue_arn, job_definition_arn, aws_credentials | ||
| ): | ||
| @flow | ||
| async def test_flow(): | ||
| return await batch_submit( | ||
| "batch_test_job", | ||
| job_queue_arn, | ||
| job_definition_arn, | ||
| aws_credentials, | ||
| ) | ||
|
|
||
| job_id = await test_flow() | ||
| assert_valid_job_id(job_id) | ||
|
|
||
|
|
||
| async def test_batch_submit_explicit_async( | ||
| job_queue_arn, job_definition_arn, aws_credentials | ||
| ): | ||
| job_id = await batch_submit_async( | ||
| "batch_test_job", | ||
| job_queue_arn, | ||
| job_definition_arn, | ||
| aws_credentials, | ||
| ) | ||
| assert_valid_job_id(job_id) | ||
|
|
||
|
|
||
| async def test_batch_submit_force_sync_from_async( | ||
| job_queue_arn, job_definition_arn, aws_credentials | ||
| ): | ||
| job_id = batch_submit( | ||
| "batch_test_job", | ||
| job_queue_arn, | ||
| job_definition_arn, | ||
| aws_credentials, | ||
| _sync=True, | ||
| ) | ||
| assert_valid_job_id(job_id) |
There was a problem hiding this comment.
i tried a couple permutations of pytest tricks but explicitly writing out the individual cases felt simplest to me
There was a problem hiding this comment.
The smallest of nits, but can you group the tests into classes so it's easier to find the tests for each implementation?
zzstoatzz
force-pushed
the
async-dispatch-aws-batch
branch
from
78ef6a3
to
8d3ab49
Compare
zzstoatzz
changed the title
prefect_aws.batchprefect_aws.batch off sync_compatible
desertaxle
reviewed
Nov 19, 2024
Comment on lines
+25
to
+30
| def _is_acceptable_callable(obj: Union[Callable, Task]) -> bool: | ||
| if inspect.iscoroutinefunction(obj): | ||
| return True | ||
| if isinstance(obj, Task) and inspect.iscoroutinefunction(obj.fn): | ||
| return True | ||
| return False |
There was a problem hiding this comment.
Looks like we'll need to bump the version of prefect in prefect-aws to get this change?
| from prefect_aws.credentials import AwsCredentials | ||
|
|
||
|
|
||
| @task | ||
| @sync_compatible | ||
| async def batch_submit( | ||
| async def batch_submit_async( |
There was a problem hiding this comment.
Should this be abatch_submit?
Comment on lines
87
to
128
| assert_valid_job_id(job_id) | ||
|
|
||
|
|
||
| async def test_batch_submit_async_dispatch( | ||
| job_queue_arn, job_definition_arn, aws_credentials | ||
| ): | ||
| @flow | ||
| async def test_flow(): | ||
| return await batch_submit( | ||
| "batch_test_job", | ||
| job_queue_arn, | ||
| job_definition_arn, | ||
| aws_credentials, | ||
| ) | ||
|
|
||
| job_id = await test_flow() | ||
| assert_valid_job_id(job_id) | ||
|
|
||
|
|
||
| async def test_batch_submit_explicit_async( | ||
| job_queue_arn, job_definition_arn, aws_credentials | ||
| ): | ||
| job_id = await batch_submit_async( | ||
| "batch_test_job", | ||
| job_queue_arn, | ||
| job_definition_arn, | ||
| aws_credentials, | ||
| ) | ||
| assert_valid_job_id(job_id) | ||
|
|
||
|
|
||
| async def test_batch_submit_force_sync_from_async( | ||
| job_queue_arn, job_definition_arn, aws_credentials | ||
| ): | ||
| job_id = batch_submit( | ||
| "batch_test_job", | ||
| job_queue_arn, | ||
| job_definition_arn, | ||
| aws_credentials, | ||
| _sync=True, | ||
| ) | ||
| assert_valid_job_id(job_id) |
There was a problem hiding this comment.
The smallest of nits, but can you group the tests into classes so it's easier to find the tests for each implementation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #15008
migrates
prefect_aws.batchtasks to explicit sync / async viaasync_dispatchalso updates
async_dispatchto allow dispatching async task objectswill continue with
prefect_awsafter this PR