Imgloader fixes #58
Merged
Imgloader fixes #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tpietzsch , you are still using a Virtual Bioformats loader, right? One can choose between virtual and not virtual during dataset definition. Virtual is superior for many reasons, but specifically because it works with Spark where loaded images and not shared. |
|
Yes, I just replaced the implementation of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up
FileMapImgLoaderLOCI2.For the "Dataset for Stitching As TIFF (unaligned, no BigStitcher project defined)" linked from BigStitcher-Spark, I'm now down to ~5s for resaving from ~40s before Use new BlockSupplier API for downsampling #56)
Start fixing the impenetrable FileList code (
Map<Integer,List<Pair<File,Pair<Integer,Integer>>>>...) by introducingFileMapEntryto replacePair<File,Pair<Integer,Integer>>.