Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big red warning message into PrestaShop when not using the right PHP version #20862

Open
matks opened this issue Sep 4, 2020 · 19 comments
Open
Assignees
Labels
BO Category: Back Office Feature Type: New Feature PM ✔️ Status: check done, behavior approved Ready Status: Issue is ready to be worked on UX ✔️ Status: check done, design approved Wording ✔️ Status: check done, wording approved

Comments

@matks
Copy link
Contributor

matks commented Sep 4, 2020

Is your feature request related to a problem?

I just saw 2 bug reports about very, very weird behaviors ... the people reporting them said "I upgraded to 1.7.6.7 and now this page does [weird behavior]". Obviously I could not reproduce the bugs.

Finally the main reason behind this very weird bug was they were not using the right PHP version.

Describe the solution you'd like

In order not to waste users time and PrestaShop team time, I suggest that, on Back Office pages, when we detect that user PHP version is not supported, we display a BIG RED MESSAGE telling this to user.

This will help users troubleshoot issues faster 😄

The message would say You are using a PHP version that is not supported and this can affect your store. Please check PHP requirements and change for the suitable PHP version. in Admin.Notifications.Warning. - edited by @LouiseBonnard on September 11th, following @Julievrz's wording suggestion.

It should be displayed only on the dashboard. Here is the design mockup:

image

supportedphp-alert (1)

Here are the specifications: PrestaShop/prestashop-specs#173

@prestashop-issue-bot
Copy link

Thanks for opening this issue! We will help you to keep its state consistent

@florine2623 florine2623 added Feature Type: New Feature Improvement Type: Improvement Waiting for PM Status: action required, waiting for product feedback BO Category: Back Office labels Sep 4, 2020
@florine2623
Copy link
Contributor

Ping @PrestaShop/prestashop-product-team
Here's a great improvement suggested by @matks.
Do you think it could be implemented ?

Thanks!

@eternoendless eternoendless added the Needs Specs Status: issue needs to be specified label Sep 4, 2020
@LouiseBonnard LouiseBonnard added PM ✔️ Status: check done, behavior approved and removed Waiting for PM Status: action required, waiting for product feedback labels Sep 7, 2020
@LouiseBonnard
Copy link
Contributor

Nice idea, thanks @matks! I suggest displaying it every time a user goes to his store, so at each connection, on the first page displayed. A popup like a modal might be more effective since it requires an action from the user to either Upgrade (redirecting to https://www.php.net/downloads?) or Close the window. @TristanLDD, @prestascott, what do you recommend?

For the warning message, I propose You are using a PHP version that is no longer supported and this can affect your store. Please upgrade to PHP %s version. in Admin.Notifications.Warning. And what about What do you think, @matks and @Julievrz?

@LouiseBonnard LouiseBonnard added Waiting for UX Status: action required, waiting for design feedback Waiting for wording Status: action required, waiting for wording labels Sep 7, 2020
@PierreRambaud
Copy link
Contributor

Nice idea, thanks @matks! I suggest displaying it every time a user goes to his store, so at each connection, on the first page displayed. A popup like a modal might be more effective since it requires an action from the user to either Upgrade (redirecting to https://www.php.net/downloads?) or Close the window. @TristanLDD, @prestascott, what do you recommend?

For the warning message, I propose You are using a PHP version that is no longer supported and this can affect your store. Please upgrade to PHP %s version. in Admin.Notifications.Warning. And what about What do you think, @matks and @Julievrz?

You're considering they are using only and outdated version. What about recent versions of PHP that are not already supported?

@LouiseBonnard
Copy link
Contributor

We could think about a wording that would apply to both cases then.

@Julievrz
Copy link
Contributor

Julievrz commented Sep 7, 2020

We could think about a wording that would apply to both cases then.

What do you think of this sentence: " You are using a PHP version that is not supported and this can affect your store. Please check PHP requirements and change for the suitable PHP version."

@LouiseBonnard LouiseBonnard self-assigned this Sep 7, 2020
@PululuK
Copy link
Member

PululuK commented Sep 8, 2020

Hi @matks
We also need to add an alert on system information, something like this :
image

@LouiseBonnard LouiseBonnard added Wording ✔️ Status: check done, wording approved and removed Waiting for wording Status: action required, waiting for wording labels Sep 11, 2020
@prestascott
Copy link

Hi everyone!

Thank you for your report @matks!

Adding a modal warning message can be useful but can also be aggressive for our users.
Like @LouiseBonnard said, I also suggest to display the modal only at the connection. And then, once he closes it, it's still displayed on the page but smaller as an alert so this information isn't lost.

Usually, a modal contains a title, a description and buttons. I suggest to add a title like "PHP update required" and a button "Check PHP requirements" for example in order to help users solving their PHP version issue.

Wdyt?

@matks
Copy link
Contributor Author

matks commented Sep 14, 2020

Hi everyone!

Thank you for your report @matks!

Adding a modal warning message can be useful but can also be aggressive for our users.
Like @LouiseBonnard said, I also suggest to display the modal only at the connection. And then, once he closes it, it's still displayed on the page but smaller as an alert so this information isn't lost.

Usually, a modal contains a title, a description and buttons. I suggest to add a title like "PHP update required" and a button "Check PHP requirements" for example in order to help users solving their PHP version issue.

Wdyt?

I'm good with this 👍

Can I use the "standard modal display" we use, for example, for "bulk delete" actions ?

So if I try to make a summary;

  1. When user logins into BO and the shop is running a PHP version not compatible, and he reaches the dashboard, we display the modal. User can either click on the "Check PHP requirements" CTA or close it.

  2. Whether he closes the modal or clicks the CTA, we close the modal. We dont reopen the modal as long as user stays connected. However we have a warning message inside Dashboard.

  3. If user logs out then logs-in, we re-trigger item 1: we show the modal.

  4. Following @PululuK suggestion, the warning displayed inside Dashboard can be displayed into "System informations" BO page too, with php version being displayed in red to attract user attention.

@prestascott
Copy link

I'm good with your summary, thanks! :)

@prestascott prestascott added UX ✔️ Status: check done, design approved and removed Waiting for UX Status: action required, waiting for design feedback labels Sep 14, 2020
@LouiseBonnard
Copy link
Contributor

It's all okay for me except the first point:

When user logins into BO and the shop is running a PHP version not compatible, and he reaches the dashboard, we display the modal. User can either click on the "Check PHP requirements" CTA or close it.

Note that the user does not necessarily reach the dashboard when he/she logs in so I assume the modal must be displayed at each connection, whatever the page reached.

Also, in some cases, the Welcome module could be enabled, which displays popping up onboarding journey. It might be difficult to display the two so if we need to set up an order of preference, I'm in favor of displaying the PHP modal before the onboarding journey.

@LouiseBonnard LouiseBonnard added Ready Status: Issue is ready to be worked on and removed Needs Specs Status: issue needs to be specified labels Sep 14, 2020
@LouiseBonnard LouiseBonnard added Needs Specs Status: issue needs to be specified Waiting for UX Status: action required, waiting for design feedback labels Sep 14, 2020
@PululuK
Copy link
Member

PululuK commented Sep 16, 2020

@PululuK It's a nice idea but this component doesn't exist. I guess we can create it but it won't be red and will be yellow since it's a warning.
I still suggest to add a modal instead that only appears when users log in.

Here is what it would look like as an alert :

@prestascott An alert already exists on this page :
Capture du 2020-09-16 15-34-27

But the warning idea looks good to me !

@prestascott
Copy link

prestascott commented Sep 16, 2020

@PululuK I'm glad that the warning idea looks good to you! 👍

And yes, in fact there's already an alert on this page but this is an old design that we're trying to move on.
This Dashboard page hasn't been migrated yet that's why we prefer using our new components such as the alert that I added.

@prestascott prestascott added UX ✔️ Status: check done, design approved and removed Waiting for UX Status: action required, waiting for design feedback labels Sep 16, 2020
@LouiseBonnard LouiseBonnard added Waiting for PM Status: action required, waiting for product feedback Waiting for UX Status: action required, waiting for design feedback and removed PM ✔️ Status: check done, behavior approved UX ✔️ Status: check done, design approved labels Oct 5, 2020
@sarahdib sarahdib removed the Improvement Type: Improvement label Oct 14, 2020
@LouiseBonnard
Copy link
Contributor

Right! I discussed with @prestascott and, indeed, the warning solution is less aggressive to users than the modal window so we've decided to drop the first idea and focus on the warning notification. Our job is to warn the users that they will have difficulties if they do not use the right PHP version. Once this message is sent, it is up to the users to get a suitable PHP version.

Here are the specifications, it's ready for review: PrestaShop/prestashop-specs#173

@LouiseBonnard LouiseBonnard added PM ✔️ Status: check done, behavior approved and removed Waiting for PM Status: action required, waiting for product feedback labels Nov 13, 2020
@prestascott prestascott added UX ✔️ Status: check done, design approved and removed Waiting for UX Status: action required, waiting for design feedback labels Nov 13, 2020
@LouiseBonnard LouiseBonnard added Ready Status: Issue is ready to be worked on and removed Needs Specs Status: issue needs to be specified labels Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BO Category: Back Office Feature Type: New Feature PM ✔️ Status: check done, behavior approved Ready Status: Issue is ready to be worked on UX ✔️ Status: check done, design approved Wording ✔️ Status: check done, wording approved
Projects
None yet
Development

No branches or pull requests