-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big red warning message into PrestaShop when not using the right PHP version #20862
Comments
Thanks for opening this issue! We will help you to keep its state consistent |
Ping @PrestaShop/prestashop-product-team Thanks! |
Nice idea, thanks @matks! I suggest displaying it every time a user goes to his store, so at each connection, on the first page displayed. A popup like a modal might be more effective since it requires an action from the user to either Upgrade (redirecting to https://www.php.net/downloads?) or Close the window. @TristanLDD, @prestascott, what do you recommend? For the warning message, I propose You are using a PHP version that is no longer supported and this can affect your store. Please upgrade to PHP %s version. in Admin.Notifications.Warning. And what about What do you think, @matks and @Julievrz? |
You're considering they are using only and outdated version. What about recent versions of PHP that are not already supported? |
We could think about a wording that would apply to both cases then. |
What do you think of this sentence: " You are using a PHP version that is not supported and this can affect your store. Please check PHP requirements and change for the suitable PHP version." |
Hi @matks |
Hi everyone! Thank you for your report @matks! Adding a modal warning message can be useful but can also be aggressive for our users. Usually, a modal contains a title, a description and buttons. I suggest to add a title like "PHP update required" and a button "Check PHP requirements" for example in order to help users solving their PHP version issue. Wdyt? |
I'm good with this 👍 Can I use the "standard modal display" we use, for example, for "bulk delete" actions ? So if I try to make a summary;
|
I'm good with your summary, thanks! :) |
It's all okay for me except the first point:
Note that the user does not necessarily reach the dashboard when he/she logs in so I assume the modal must be displayed at each connection, whatever the page reached. Also, in some cases, the Welcome module could be enabled, which displays popping up onboarding journey. It might be difficult to display the two so if we need to set up an order of preference, I'm in favor of displaying the PHP modal before the onboarding journey. |
@prestascott An alert already exists on this page : But the warning idea looks good to me ! |
@PululuK I'm glad that the warning idea looks good to you! 👍 And yes, in fact there's already an alert on this page but this is an old design that we're trying to move on. |
Right! I discussed with @prestascott and, indeed, the warning solution is less aggressive to users than the modal window so we've decided to drop the first idea and focus on the warning notification. Our job is to warn the users that they will have difficulties if they do not use the right PHP version. Once this message is sent, it is up to the users to get a suitable PHP version. Here are the specifications, it's ready for review: PrestaShop/prestashop-specs#173 |
Is your feature request related to a problem?
I just saw 2 bug reports about very, very weird behaviors ... the people reporting them said "I upgraded to 1.7.6.7 and now this page does [weird behavior]". Obviously I could not reproduce the bugs.
Finally the main reason behind this very weird bug was they were not using the right PHP version.
Describe the solution you'd like
In order not to waste users time and PrestaShop team time, I suggest that, on Back Office pages, when we detect that user PHP version is not supported, we display a BIG RED MESSAGE telling this to user.
This will help users troubleshoot issues faster 😄
The message would say You are using a PHP version that is not supported and this can affect your store. Please check PHP requirements and change for the suitable PHP version. in Admin.Notifications.Warning. - edited by @LouiseBonnard on September 11th, following @Julievrz's wording suggestion.
It should be displayed only on the dashboard. Here is the design mockup:
Here are the specifications: PrestaShop/prestashop-specs#173
The text was updated successfully, but these errors were encountered: