Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the PHP warning #173

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

LouiseBonnard
Copy link
Contributor

@LouiseBonnard LouiseBonnard commented Nov 13, 2020

Questions Answers
Description? Specify the warning notification displayed in the Dashboard when an unsupported PHP version is detected.
Fixed ticket? Specifies PrestaShop/PrestaShop#20862.

@Robin-Fischer-PS Robin-Fischer-PS removed the Waiting for QA Waiting for QA review label Nov 18, 2020
@prestascott prestascott removed the Waiting for UX Waiting for UX review label Nov 19, 2020
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, what happens if

  • user installs PS 1.7.7 with php7.4
  • so we display the yellow warning
  • user downgrades php to php7.3
  • so we display the green message once, then nothing
  • now user upgrades PS 1.7.7 to PS 1.7.9
  • and unfortunately PS 1.7.9 is not compatible with php7.3 ! it needs php7.4 or php8.0
  • so we should display again the yellow warning?

back-office/dashboard.md Outdated Show resolved Hide resolved
@marionf marionf removed the Waiting for dev Waiting for dev review label Jan 28, 2021
@MatShir
Copy link
Contributor

MatShir commented Feb 9, 2021

Todo:
@matks' case is handled, just need to be clarified

@LouiseBonnard
Copy link
Contributor Author

LouiseBonnard commented Feb 9, 2021

@matks, @MatShir, there are two cases at stake, starting from the 1.7.8 version:

  1. the PHP version matches the PS version: no warning message
  2. the PHP version doesn't match the PS version: a warning message is displayed. The warning message is the same for inferior or superior not supported version,

@marionf marionf requested a review from matks March 11, 2021 13:56
@marionf marionf added the Waiting for dev Waiting for dev review label Mar 11, 2021
@marionf
Copy link
Contributor

marionf commented Mar 11, 2021

@matks Could you please verify a last time this specs and tell us if it's ok for you before the merge ?

@matks
Copy link
Contributor

matks commented Mar 12, 2021

Hi @marionf What about this usecase

user installs PS 1.7.7 with php7.4
so we display the yellow warning
user downgrades php to php7.3
so we display the green message once, then nothing
now user upgrades PS 1.7.7 to PS 1.7.9
and unfortunately PS 1.7.9 is not compatible with php7.3 ! it needs php7.4 or php8.0
so we should display again the yellow warning?

@MatShir
Copy link
Contributor

MatShir commented Mar 12, 2021

The only cases can we handle are:

  • the PHP version matches the PS version: no warning message
  • the PHP version doesn't match the PS version: a warning message is displayed. The warning message is the same for inferior or superior not supported version
    @matks which handle your cases

# **SPECIFICATIONS - DASHBOARD PAGE**


_As a user, I want to know when my PHP version is not suitable - no longer supported or not yet supported._
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_As a user, I want to know when my PHP version is not suitable - no longer supported or not yet supported._
_As a user, I want to know when my PHP version is not suitable - no longer supported or not yet supported._
If the PHP version matches the PHP compatibility of PrestaShop: no warning message is displayed.
If the PHP version doesn't match the PHP compatibility of PrestaShop: a warning message is displayed. The warning message is the same for inferior or superior not supported version.

Copy link
Contributor

@MatShir MatShir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add a last comment, to make it more explicit. WDYT @matks @marionf

@matks
Copy link
Contributor

matks commented Mar 12, 2021

@MatShir My usecase is "what happens when on Monday I see the warning message, then on Tuesday I modify my php version, now the message is dismissed, then on Wednesday I upgrade my shop, then on Thursday again my PHP version is not good but I have previously already dismissed the message"

@MatShir
Copy link
Contributor

MatShir commented Mar 12, 2021

@matks I get it now, thanks for the clarifications.
I see 2 options:

  • this use case that can be done on a V2, it looks like an edge case. BC people upgrading their PHP version should be aware of the compatibility of PS, but people can forget to follow the PS compatibility.

Upgrading first PHP then upgrading the version should work since there is a common version (cf. https://devdocs.prestashop.com/1.7/basics/installation/system-requirements/#php-compatibility-chart)

  • The message state is reset to any PHP version changes
    If the second option is hard to implement, we should focus on the common uses cases with "is your shop compatible ? Yes or not"

WDTY ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review required Specifications to be reviewed Waiting for dev Waiting for dev review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants