-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify the PHP warning #173
base: master
Are you sure you want to change the base?
Conversation
LouiseBonnard
commented
Nov 13, 2020
•
edited by eternoendless
Loading
edited by eternoendless
Questions | Answers |
---|---|
Description? | Specify the warning notification displayed in the Dashboard when an unsupported PHP version is detected. |
Fixed ticket? | Specifies PrestaShop/PrestaShop#20862. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, what happens if
- user installs PS 1.7.7 with php7.4
- so we display the yellow warning
- user downgrades php to php7.3
- so we display the green message once, then nothing
- now user upgrades PS 1.7.7 to PS 1.7.9
- and unfortunately PS 1.7.9 is not compatible with php7.3 ! it needs php7.4 or php8.0
- so we should display again the yellow warning?
Todo: |
Co-authored-by: LouiseBonnard <[email protected]>
@matks Could you please verify a last time this specs and tell us if it's ok for you before the merge ? |
Hi @marionf What about this usecase
|
The only cases can we handle are:
|
# **SPECIFICATIONS - DASHBOARD PAGE** | ||
|
||
|
||
_As a user, I want to know when my PHP version is not suitable - no longer supported or not yet supported._ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_As a user, I want to know when my PHP version is not suitable - no longer supported or not yet supported._ | |
_As a user, I want to know when my PHP version is not suitable - no longer supported or not yet supported._ | |
If the PHP version matches the PHP compatibility of PrestaShop: no warning message is displayed. | |
If the PHP version doesn't match the PHP compatibility of PrestaShop: a warning message is displayed. The warning message is the same for inferior or superior not supported version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MatShir My usecase is "what happens when on Monday I see the warning message, then on Tuesday I modify my php version, now the message is dismissed, then on Wednesday I upgrade my shop, then on Thursday again my PHP version is not good but I have previously already dismissed the message" |
@matks I get it now, thanks for the clarifications.
Upgrading first PHP then upgrading the version should work since there is a common version (cf. https://devdocs.prestashop.com/1.7/basics/installation/system-requirements/#php-compatibility-chart)
WDTY ? |