Fixes Issue #66: ConcurrentTimedRotatingFileHandler rotating gzip fil… #67
+128
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es fails The gzip extension is already present in the return value of `getFilesToDelete` in Python's `TimedRotatingFileHandler` and doesn't needed to be added. This was causing it to fail to rollover properly in Timed mode.
|
Hi @Preston-Landers , |
|
@SukeerthiBJ that's a good question. I'm not sure. I'll check into it later. I never use the .tar.gz files myself, just the whl. If the whl file doesn't work for you for some reason, you could always Git clone the repo and install it from there running the setup.py script. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…es fails
The gzip extension is already present in the return value of
getFilesToDeletein Python'sTimedRotatingFileHandlerand doesn't needed to be added. This was causing it to fail to rollover properly in Timed mode.