WIP: feat: add HKTAN Segment Version 7 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielr1996
changed the title
|
Hey Daniel, any progress or ideas on this? |
|
I didn't mean to implement the method at all, it was just a fix because my app crashed when Tan method version 7 was just available, even tough I didn't use it. |
|
hm... any guidance on how to get this implementation going? how are you guys testing btw? (cc @Prior99 ) just with your personal accounts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses #13 and adds HKTAN Segment Version #7. And resolves the issue I had while using
clients.accounts(), however the use of the tan methods is not yet implemented.See Section B.5.2 c) of the [PIN/TAN] Specification for the added fields