fix: Synchronize LDAP users using their identifier

Probesys · Aug 14, 2023 · baa12e6 · baa12e6
1 parent 2acfbb7
commit baa12e6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/MessageHandler/SynchronizeLdapHandler.php b/src/MessageHandler/SynchronizeLdapHandler.php
@@ -45,10 +45,11 @@ public function __invoke(SynchronizeLdap $message): void
         $countErrors = 0;
 
         foreach ($ldapUsers as $ldapUser) {
-            $user = $userRepository->findOneBy(['email' => $ldapUser->getEmail()]);
+            $user = $userRepository->findOneBy([
+                'ldapIdentifier' => $ldapUser->getLdapIdentifier(),
+            ]);
 
             if ($user) {
-                $user->setLdapIdentifier($ldapUser->getLdapIdentifier());
                 $user->setEmail($ldapUser->getEmail());
                 $user->setName($ldapUser->getName());
 

diff --git a/tests/MessageHandler/SynchronizeLdapHandlerTest.php b/tests/MessageHandler/SynchronizeLdapHandlerTest.php
@@ -45,16 +45,16 @@ public function testInvokeUpdateUsers(): void
         /** @var MessageBusInterface */
         $bus = $container->get(MessageBusInterface::class);
         $user = UserFactory::createOne([
-            'email' => 'charlie@example.com',
+            'email' => 'cgature@example.com',
             'name' => 'C. Gature',
-            'ldapIdentifier' => 'cgature',
+            'ldapIdentifier' => 'charlie',
         ]);
 
         $bus->dispatch(new SynchronizeLdap());
 
         $user->refresh();
-        $this->assertSame('charlie', $user->getLdapIdentifier());
         $this->assertSame('[email protected]', $user->getEmail());
         $this->assertSame('Charlie Gature', $user->getName());
+        $this->assertSame('charlie', $user->getLdapIdentifier());
     }
 }