new: Allow to login using LDAP #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marien-probesys
force-pushed
the
new/ldap-auth
branch
6 times, most recently
from
c570f9d
to
72418b6
Compare
The server is configured as an optional service in the Docker Compose file. It is started by enabling the `ldap` profile. This can be done with `make docker-start LDAP=true`. The users are defined in a ldif file placed under `docker/ldap-ldifs/` which is mounted as a volume in the Docker Compose file. Only Charlie and Dominique users are defined as the other users will continue to login as "local" users. I've enabled `BITNAMI_DEBUG` to help to understand the errors when we update the ldif file. It's not very verbose anyway.
marien-probesys
force-pushed
the
new/ldap-auth
branch
from
72418b6
to
257917e
Compare
marien-probesys
force-pushed
the
new/ldap-auth
branch
from
257917e
to
9ae797a
Compare
marien-probesys
commented
Aug 4, 2023
marien-probesys
force-pushed
the
new/ldap-auth
branch
from
8239c89
to
2796255
Compare
The Authenticator is responsible for verifying user credentials. Symfony provides several Authenticators, including the “Form Login” that we already use, and a LDAP variant. Unfortunately, there is no way to log in from a database or a LDAP directory depending on an attribute (e.g. auth_type). So we had to write our own Authenticator.
marien-probesys
force-pushed
the
new/ldap-auth
branch
from
2796255
to
1f6115a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
#168
Changes
How to test manually
make docker-run LDAP=true[email protected] / secret→ check it works[email protected] / secret→ check it does not workcharlie / secret→ check it works[email protected]does not workdominique / secret→ check it works and that the user[email protected]now exists in DBChecklist