Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: Allow admin to change the LDAP identifiers #402

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

marien-probesys
Copy link
Member

@marien-probesys marien-probesys commented Aug 14, 2023

Related issue(s)

#168

Changes

  • in admin, forbid changing name, email and password of users if ldapIdentifier is set
  • add an input to change the ldapIdentifier
  • when synchronizing, search users by their ldapIdentifier instead of email

How to test manually

  • go to the settings > users
  • edit charlie user → check that you can't change email, name or password
  • empty the ldapIdentifier input → check that you can now change email, name and password
  • set "charlie" back to the ldapIdentifier and run ./docker/bin/console app:ldap:sync
  • check that the information are back

Checklist

  • code is manually tested
  • permissions / authorizations are verified
  • interface works on both mobiles and big screens
  • accessibility has been tested
  • tests are up-to-date
  • locales are synchronized
  • copyright notices are up-to-date
  • documentation is up-to-date (including migration notes)

@marien-probesys marien-probesys force-pushed the imp/admin-update-ldap-identifiers branch from 700dc19 to 5f28d8f Compare August 14, 2023 14:22
@marien-probesys marien-probesys force-pushed the imp/admin-update-ldap-identifiers branch from efc91bc to 75e4ce7 Compare August 14, 2023 14:29
@marien-probesys marien-probesys merged commit 75e4ce7 into main Aug 14, 2023
6 checks passed
@marien-probesys marien-probesys deleted the imp/admin-update-ldap-identifiers branch August 14, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant