Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: Allow to detach documents when posting a message #414

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

marien-probesys
Copy link
Member

@marien-probesys marien-probesys commented Aug 28, 2023

Related issue(s)

#149

Changes

  • add an endpoint to delete a MessageDocument
  • return the url to delete a MessageDocument when uploading a file
  • when uploading a file, add a "delete" button to detach it
  • add a handler to remove a document asynchronously, remove it from the TinyMCE editor and from the hidden inputs

How to test manually

  • start a new message
  • upload an image
  • detach the file → check it disappears from the editor
  • post the message → check there is no attachments

Checklist

  • code is manually tested
  • permissions / authorizations are verified
  • interface works on both mobiles and big screens
  • accessibility has been tested
  • tests are up-to-date
  • locales are synchronized
  • copyright notices are up-to-date
  • documentation is up-to-date (including migration notes)

@marien-probesys marien-probesys merged commit fdc305e into main Aug 28, 2023
6 checks passed
@marien-probesys marien-probesys deleted the imp/detach-documents branch August 28, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant