A little cleaning #191
A little cleaning #191
Conversation
I assume that plugin classes aren't supposed to be used anywhere outside of this module since all dependencies are private in Build.cs file
| @@ -103,7 +103,7 @@ class FGitSourceControlModule : public IModuleInterface | |||
| return GitSourceControlProvider; | |||
| } | |||
|
|
|||
| GITSOURCECONTROL_API static const TArray< FString > & GetEmptyStringArray() | |||
| static const TArray< FString > & GetEmptyStringArray() | |||
There was a problem hiding this comment.
I don't know how you use it internally, but in my projects, I interact with VCS through ISourceControlModule, ISourceControlProvider and UEditorAssetLibrary, UEditorAssetSubsystem in my validators and asset action utilities
So exposing such functionality seems a bit wrong architecturally, but again I'm not aware of how you use it in your code, so feel free to revert my changes
At least exposing GITSOURCECONTROL_API static const TArray< FString > & GetEmptyStringArray() seems a bit cursed
| @@ -16,7 +16,7 @@ | |||
| "Modules": [ | |||
| { | |||
| "Name": "GitSourceControl", | |||
| "Type": "UncookedOnly", | |||
| "Type": "Editor", | |||
There was a problem hiding this comment.
To my knowledge UncookedOnly is preferred
There was a problem hiding this comment.
Do we really want to be able to interact with git anyhow outside of the editor?
There was a problem hiding this comment.
Yes, there's an expectation that source control module is available outside of the editor in many Unreal tools from Epic
There was a problem hiding this comment.
just out of curiosity, could you give me an example because I couldn't find any in the engine folder
or you are talking about Borealis internal tools?
Small changes to check if you guys accept PRs from external ppl