Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make consistent with latest template #15

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

brian-rose
Copy link
Member

This PR addresses several inconsistencies in this cookbook's configuration relative to the latest version of the Cookbook template.

It's possible that this will allow this Cookbook to show up in the gallery, i.e. fix ProjectPythia/cookbook-gallery#201. We will probably have to merge this PR first and then try rebuilding the gallery.

Copy link

github-actions bot commented Jun 3, 2024

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: 3bb66e2
✅ Deployment Preview URL: https://ProjectPythia.github.io/vapor-python-cookbook/_preview/15

@brian-rose brian-rose requested a review from NihanthCW June 3, 2024 22:19
@NihanthCW
Copy link
Collaborator

Hello @brian-rose , Just checking- the changes seem to be reverting it to the basic configuration. I approved it but is there anything we need to do on our end? Is the duplication caused by the title in _config.yml ?

@brian-rose
Copy link
Member Author

Hi @NihanthCW, I don't really understand what's causing the bug in the gallery ProjectPythia/cookbook-gallery#201. Maybe this will fix it, but even if it doesn't, this PR just removes some unnecessary stuff from the config file so it should be a useful clean-up. And it won't break anything.

Let's merge this and see if it fixes the gallery problem. I don't think there's any other action you need to take.

@brian-rose brian-rose merged commit a20b1de into ProjectPythia:main Jun 4, 2024
2 checks passed
@brian-rose brian-rose deleted the update-infrastructure branch June 4, 2024 00:53
github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
@brian-rose
Copy link
Member Author

Hi @NihanthCW, glad to say that the VAPOR Cookbook now appears in the Gallery!

There was a bug in the code that generates gallery cards for cookbooks with longer descriptions. It was fixed in ProjectPythia/cookbook-gallery#204. All good now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cookbook duplicated in gallery
2 participants