feat/launch_bat_c++_build_tools #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat/launch_bat_c++_build_tools * Reorganize logs
thomasmso
reviewed
Sep 22, 2023
|
Changes made |
thomasmso
previously approved these changes
Sep 22, 2023
Co-authored-by: Thomas So <[email protected]>
thomasmso
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We exit after installing these C++ build tools, because from what I've seen the script has to be run in VS's command prompt to actually find the C++ compiler.
Also, this
wingetcommand opens the Visual Studio Installer GUI. There are multiple ways to install the C++ tools and they are large downloads, so I wanted to give the user a chance to decide whether to continue (this was the smallest set of tools I could use successfully) or figure out their own packages.