Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure formatting in pyproject.toml; set required python to >=3.8 #95

Merged
merged 17 commits into from
Dec 14, 2023

Conversation

RalfG
Copy link
Contributor

@RalfG RalfG commented Sep 25, 2023

Added

  • isort and black configurations in pyproject.toml (with max line length of 120)
  • Black check in GitHub Actions
  • New CI workflow with Flake8 linting and Black checks for code in ./streamlit

Changed

  • Removed support for Python 3.7 (end of life), added 3.11 to CI checks

Removed

  • Removed some unused imports

Note: Two new CI checks are failing because the code base has not been formatted with Black yet.

@RalfG RalfG marked this pull request as ready for review September 25, 2023 14:27
@enryH
Copy link
Member

enryH commented Sep 25, 2023

Let's update the formatting continuously on the other branches and gradually move to black. I think this should not fail by tomorrow.


[tool.black]
line-length = 120
target-version = ['py38']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
target-version = ['py38']
target-version = ["py38", "py39", "py310", "py311"]

enryH pushed a commit that referenced this pull request Nov 19, 2023
- see open PR #95
@RobbinBouwmeester RobbinBouwmeester merged commit 297bb6f into main Dec 14, 2023
7 checks passed
@RobbinBouwmeester RobbinBouwmeester deleted the specify-formatting branch December 14, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants