Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Leo] Add global constants #65

Merged
merged 2 commits into from
Oct 12, 2023
Merged

[Leo] Add global constants #65

merged 2 commits into from
Oct 12, 2023

Conversation

evan-schott
Copy link
Contributor

Since ProvableHQ/leo#2606 has been merged into Leo

@evan-schott evan-schott requested a review from acoglio October 5, 2023 18:01
@evan-schott evan-schott changed the title Add global constants [Leo] Add global constants Oct 5, 2023
acoglio
acoglio requested changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@acoglio acoglio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It look structurally good. Would you mind changing const-declaration to constant-declaration, since we try and use full words in the nonterminals of the grammar?

@evan-schott evan-schott requested a review from acoglio October 11, 2023 21:48
@acoglio acoglio merged commit a36b598 into master Oct 12, 2023
@acoglio acoglio deleted the feat/global-constants branch October 12, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acoglio acoglio acoglio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evan-schott @acoglio