-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hide inputed private key when import an account #10062
Conversation
This issue does not qualify for a contributor badge because a bot is suspected. If you are not a bot, please reach out to us directly and provide proof. |
This doesn't for the contributor badge, but add a new feature to leo, how to contact you sir? |
@d0cd Sincerely thanks. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## testnet3 #10062 +/- ##
============================================
- Coverage 75.65% 75.47% -0.19%
============================================
Files 203 203
Lines 7049 7054 +5
Branches 7049 7054 +5
============================================
- Hits 5333 5324 -9
- Misses 1716 1730 +14 ☔ View full report in Codecov by Sentry. |
It's fine😀. BTW, the issue #10060 is still closed now, could u plz help me to reopen it, thanks |
@aharshbe @d0cd Hi, looking forward for your review~ |
thank u |
For what? |
Thank you for the instructions. I followed the instructions |
@aharshbe Hi sir, could you please help me review this pr, thanks 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we incorporate the changes from #10018 and use the --discreet
flag for the password prompt?
@d0cd Hi sir, Did you mean that incorporate the changes from #10018 to this pr, then close pr 10018? And add IMO these two pr are different, maybe we can merge #10018 first, and I will merge the |
@d0cd Hi sir, suggestion changes have been addressed, looking forward to your review again |
This reverts commit ba6b9c4.
@d0cd Hi sir, can we get this merge then? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: d0cd <[email protected]>
@Halimao would mind fixing the build and conflict? We'll push the PR through afterwords |
Signed-off-by: Halimao <[email protected]>
Addressed~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Motivation
close #10060
Support to hide the inputed private key when we run
leo account import
. And the private key in output will show discreetly, see another pr 10018