Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide inputed private key when import an account #10062

Merged
merged 10 commits into from
Feb 29, 2024

Conversation

Halimao
Copy link
Contributor

@Halimao Halimao commented Nov 28, 2023

Motivation

close #10060

Support to hide the inputed private key when we run leo account import. And the private key in output will show discreetly, see another pr 10018

image

@ghost
Copy link

ghost commented Nov 28, 2023

This issue does not qualify for a contributor badge because a bot is suspected. If you are not a bot, please reach out to us directly and provide proof.

@ghost ghost closed this Nov 28, 2023
@Halimao
Copy link
Contributor Author

Halimao commented Nov 28, 2023

This issue does not qualify for a contributor badge because a bot is suspected. If you are not a bot, please reach out to us directly and provide proof.

This doesn't for the contributor badge, but add a new feature to leo, how to contact you sir?

@d0cd d0cd reopened this Nov 29, 2023
@Halimao
Copy link
Contributor Author

Halimao commented Nov 29, 2023

@d0cd Sincerely thanks.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (a2e3155) 75.65% compared to head (9297c44) 75.47%.

Files Patch % Lines
leo/cli/commands/account.rs 0.00% 9 Missing ⚠️
errors/src/errors/cli/cli_errors.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           testnet3   #10062      +/-   ##
============================================
- Coverage     75.65%   75.47%   -0.19%     
============================================
  Files           203      203              
  Lines          7049     7054       +5     
  Branches       7049     7054       +5     
============================================
- Hits           5333     5324       -9     
- Misses         1716     1730      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghost
Copy link

ghost commented Nov 29, 2023

Hey there @Halimao, so very sorry for closing your issue.

We're currently battling a bot army of contributor spam and, unfortunately, the script I wrote had a random bug that included your issue in it. Thank you for working with us and for your patience!

Also, thank you @d0cd for the save! 🙂

@Halimao
Copy link
Contributor Author

Halimao commented Nov 29, 2023

Hey there @Halimao, so very sorry for closing your issue.

We're currently battling a bot army of contributor spam and, unfortunately, the script I wrote had a random bug that included your issue in it. Thank you for working with us and for your patience!

Also, thank you @d0cd for the save! 🙂

It's fine😀. BTW, the issue #10060 is still closed now, could u plz help me to reopen it, thanks

@Halimao
Copy link
Contributor Author

Halimao commented Dec 3, 2023

@aharshbe @d0cd Hi, looking forward for your review~

@bebbb1990
Copy link

thank u

@Halimao
Copy link
Contributor Author

Halimao commented Dec 9, 2023

thank u

For what?

@bebbb1990
Copy link

Thank you for the instructions. I followed the instructions

@Halimao
Copy link
Contributor Author

Halimao commented Jan 5, 2024

@aharshbe Hi sir, could you please help me review this pr, thanks 😀

Copy link
Collaborator

@d0cd d0cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we incorporate the changes from #10018 and use the --discreet flag for the password prompt?

@Halimao
Copy link
Contributor Author

Halimao commented Jan 16, 2024

Could we incorporate the changes from #10018 and use the --discreet flag for the password prompt?

@d0cd Hi sir, Did you mean that incorporate the changes from #10018 to this pr, then close pr 10018?

And add --discreet flag for using password prompt to input the private key?

IMO these two pr are different, maybe we can merge #10018 first, and I will merge the testnet3 branch's new changes to this pr

@Halimao Halimao requested a review from d0cd January 18, 2024 02:50
@Halimao
Copy link
Contributor Author

Halimao commented Jan 18, 2024

@d0cd Hi sir, suggestion changes have been addressed, looking forward to your review again

Cargo.toml Outdated Show resolved Hide resolved
@Halimao
Copy link
Contributor Author

Halimao commented Feb 1, 2024

@d0cd Hi sir, can we get this merge then?

Copy link
Collaborator

@d0cd d0cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@d0cd
Copy link
Collaborator

d0cd commented Feb 12, 2024

@Halimao would mind fixing the build and conflict? We'll push the PR through afterwords

@Halimao
Copy link
Contributor Author

Halimao commented Feb 12, 2024

@Halimao would mind fixing the build and conflict? We'll push the PR through afterwords

Addressed~

@Halimao Halimao requested a review from d0cd February 17, 2024 08:57
Copy link
Collaborator

@d0cd d0cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@d0cd d0cd merged commit 58c18f9 into ProvableHQ:testnet3 Feb 29, 2024
14 of 15 checks passed
@Halimao Halimao deleted the feat/input-cover branch March 1, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] hide user input when inputing privite key
3 participants