Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constant Folding #1933

Closed
wants to merge 23 commits into from
Closed

Constant Folding #1933

wants to merge 23 commits into from

Conversation

d0cd
Copy link
Collaborator

@d0cd d0cd commented Jul 12, 2022

TODO

@d0cd d0cd marked this pull request as draft July 12, 2022 21:22
@d0cd d0cd changed the base branch from testnet3 to feat/loop-unrolling July 12, 2022 23:40
@Centril
Copy link
Contributor

Centril commented Jul 14, 2022

N.B. to make these PR series easier to review, I'd prefer to review the diff just for the changes relevant e.g., to constant folding and not other things.

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #1933 (3515b96) into testnet3 (9756714) will increase coverage by 1.22%.
The diff coverage is 76.10%.

❗ Current head 3515b96 differs from pull request most recent head 906df51. Consider uploading reports for the commit 906df51 to get more accurate results

@@             Coverage Diff              @@
##           testnet3    #1933      +/-   ##
============================================
+ Coverage     80.19%   81.41%   +1.22%     
============================================
  Files           120      139      +19     
  Lines          4801     5924    +1123     
  Branches       4800     5924    +1124     
============================================
+ Hits           3850     4823     +973     
- Misses          951     1101     +150     
Impacted Files Coverage Δ
compiler/ast/src/lib.rs 88.33% <ø> (-1.38%) ⬇️
compiler/ast/src/statements/definition/declare.rs 16.66% <0.00%> (ø)
compiler/passes/src/lib.rs 100.00% <ø> (ø)
compiler/passes/src/loop_unrolling/mod.rs 100.00% <ø> (ø)
...mpiler/passes/src/loop_unrolling/unroll_program.rs 94.73% <ø> (ø)
compiler/passes/src/loop_unrolling/unroller.rs 100.00% <ø> (+24.70%) ⬆️
...ompiler/passes/src/symbol_table/variable_symbol.rs 50.00% <ø> (ø)
leo/errors/src/errors/input/input_errors.rs 0.00% <0.00%> (ø)
...rors/src/errors/type_checker/type_checker_error.rs 66.00% <ø> (ø)
compiler/ast/src/value/mod.rs 55.81% <50.56%> (+34.86%) ⬆️
... and 122 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Base automatically changed from feat/loop-unrolling to testnet3 July 18, 2022 22:17
@d0cd d0cd changed the base branch from testnet3 to feat/ssa July 25, 2022 18:23
@d0cd d0cd changed the base branch from feat/ssa to testnet3 July 25, 2022 18:27
@d0cd d0cd force-pushed the feat/constant-folding branch from 3515b96 to 906df51 Compare July 27, 2022 05:38
@d0cd d0cd closed this Jan 16, 2024
@d0cd
Copy link
Collaborator Author

d0cd commented Jan 16, 2024

Closing since constant folding has been implemented by #2606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants