Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global shadowing #2615

Merged
merged 24 commits into from
Oct 4, 2023
Merged

global shadowing #2615

merged 24 commits into from
Oct 4, 2023

Conversation

evan-schott
Copy link
Contributor

Resolves #2611

@evan-schott evan-schott added the bug Something isn't working label Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (feat/global-constants@372662e). Click here to learn what that means.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##             feat/global-constants    #2615   +/-   ##
========================================================
  Coverage                         ?   79.71%           
========================================================
  Files                            ?      164           
  Lines                            ?     5557           
  Branches                         ?     5557           
========================================================
  Hits                             ?     4430           
  Misses                           ?     1127           
  Partials                         ?        0

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@d0cd d0cd changed the base branch from testnet3 to feat/global-constants September 29, 2023 04:38
@d0cd d0cd changed the base branch from feat/global-constants to bug/tuple-definition September 29, 2023 04:45
@d0cd d0cd changed the base branch from bug/tuple-definition to feat/global-constants October 3, 2023 20:12
d0cd
d0cd requested changes Oct 3, 2023
View reviewed changes
errors/src/errors/type_checker/type_checker_error.rs Outdated Show resolved Hide resolved
compiler/passes/src/function_inlining/function_inliner.rs Outdated Show resolved Hide resolved
compiler/passes/src/function_inlining/function_inliner.rs Outdated Show resolved Hide resolved
compiler/parser/src/parser/file.rs Outdated Show resolved Hide resolved
compiler/passes/src/code_generation/visit_program.rs Outdated Show resolved Hide resolved
compiler/passes/src/function_inlining/inline_program.rs Outdated Show resolved Hide resolved
compiler/passes/src/function_inlining/inline_program.rs Outdated Show resolved Hide resolved
d0cd and others added 8 commits October 3, 2023 16:56
@d0cd
Merge branch 'bug/global-shadowing' into bug/tuple-definition
c16dfc0 
Signed-off-by: d0cd <[email protected]>
@d0cd
Merge pull request #2616 from AleoHQ/bug/tuple-definition
e5637bd 
tuple definition
@evan-schott @d0cd
Update errors/src/errors/type_checker/type_checker_error.rs
7334c5e 
Co-authored-by: d0cd <[email protected]>
Signed-off-by: evan-schott <[email protected]>
@evan-schott @d0cd
Update compiler/passes/src/function_inlining/function_inliner.rs
7f0dc18 
Co-authored-by: d0cd <[email protected]>
Signed-off-by: evan-schott <[email protected]>
@evan-schott @d0cd
Update compiler/passes/src/function_inlining/inline_program.rs
64649a3 
Co-authored-by: d0cd <[email protected]>
Signed-off-by: evan-schott <[email protected]>
@evan-schott @d0cd
Update compiler/parser/src/parser/file.rs
dde39bd 
Co-authored-by: d0cd <[email protected]>
Signed-off-by: evan-schott <[email protected]>
@evan-schott
constant time lookups
2942c9a
@evan-schott
formatting
00105b9
@evan-schott evan-schott requested a review from d0cd October 3, 2023 23:38
d0cd
d0cd approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@d0cd d0cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@d0cd d0cd merged commit 71f5640 into feat/global-constants Oct 4, 2023
8 checks passed
@d0cd d0cd deleted the bug/global-shadowing branch October 4, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d0cd d0cd d0cd approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] global shadowing
2 participants
@evan-schott @d0cd