Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update] Supports new features for the upcoming network reset. #2626

Merged
merged 10 commits into from
Sep 29, 2023

Conversation

d0cd
Copy link
Collaborator

@d0cd d0cd commented Sep 28, 2023

This PR,

  • adds support for self.signer
  • fixes code generation for mapping declarations
  • fixes code generation for finalize blocks
  • fixes code generation for external calls.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #2626 (67cdc56) into testnet3 (e820f7f) will decrease coverage by 0.51%.
The diff coverage is 52.11%.

@@             Coverage Diff              @@
##           testnet3    #2626      +/-   ##
============================================
- Coverage     80.03%   79.53%   -0.51%     
============================================
  Files           159      159              
  Lines          5395     5478      +83     
  Branches       5395     5478      +83     
============================================
+ Hits           4318     4357      +39     
- Misses         1077     1121      +44     
Files Coverage Δ
compiler/ast/src/program/mod.rs 100.00% <ø> (ø)
compiler/compiler/src/compiler.rs 86.66% <ø> (ø)
compiler/compiler/tests/execute.rs 90.62% <100.00%> (+0.30%) ⬆️
compiler/compiler/tests/utilities/mod.rs 90.47% <100.00%> (ø)
compiler/parser/src/parser/file.rs 73.37% <100.00%> (ø)
compiler/passes/src/code_generation/generator.rs 75.00% <100.00%> (ø)
compiler/passes/src/code_generation/mod.rs 100.00% <100.00%> (ø)
compiler/span/src/symbol.rs 83.33% <ø> (ø)
...rors/src/errors/type_checker/type_checker_error.rs 76.35% <100.00%> (ø)
...iler/passes/src/type_checking/check_expressions.rs 81.81% <0.00%> (-0.60%) ⬇️
... and 3 more

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@bendyarm bendyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d0cd d0cd merged commit 1bfcfac into testnet3 Sep 29, 2023
7 of 8 checks passed
@d0cd d0cd deleted the feat/reset-updates branch September 29, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants