Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on futures in arrays, structs, or mappings. #28466

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

mikebenfield
Copy link
Collaborator

This already wouldn't work, but would either give misleading error messages or would compile to invalid bytecode.

@mikebenfield mikebenfield requested a review from d0cd November 25, 2024 19:46
This already wouldn't work, but would either give misleading
error messages or would compile to invalid bytecode.
Copy link
Collaborator

@d0cd d0cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@d0cd d0cd merged commit 0f406a5 into mainnet Nov 27, 2024
10 checks passed
@d0cd d0cd deleted the no-futures-in-structs branch November 27, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants