Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Draft] Disassembler from Aleo instructions to Leo AST #2972

Merged
merged 15 commits into from
Dec 1, 2023
Merged

[Draft] Disassembler from Aleo instructions to Leo AST #2972

merged 15 commits into from
Dec 1, 2023

Conversation

evan-schott
Copy link
Contributor

Details

  • Converts from SnarkVM type ProgramCore to Leo AST type Stub
  • Involved creating from traits to go from SnarkVM to Leo types to allow for better synchronization
  • Included TC fix to prevent records from being valid inputs/outputs to functions and inlines

@evan-schott evan-schott force-pushed the feat/stubs-disassembler branch from 087f511 to 5b0459a Compare November 4, 2023 02:14
@evan-schott evan-schott requested a review from d0cd November 6, 2023 18:10
d0cd
d0cd requested changes Nov 21, 2023
View reviewed changes
compiler/ast/src/struct/mod.rs Outdated Show resolved Hide resolved
compiler/ast/src/struct/mod.rs Show resolved Hide resolved
compiler/passes/src/code_generation/visit_expressions.rs Outdated Show resolved Hide resolved
utils/disassembler/src/main.rs Outdated Show resolved Hide resolved
utils/disassembler/src/main.rs Outdated Show resolved Hide resolved
utils/disassembler/Cargo.toml Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
compiler/passes/src/type_checking/check_program.rs Outdated Show resolved Hide resolved
compiler/ast/src/stub/function_stub.rs Outdated Show resolved Hide resolved
compiler/ast/src/stub/function_stub.rs Outdated Show resolved Hide resolved
@evan-schott evan-schott force-pushed the feat/stubs-disassembler branch from 5b0459a to c94c2c3 Compare November 30, 2023 23:49
d0cd
d0cd approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@d0cd d0cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@d0cd d0cd merged commit ea0fce0 into feat/stubs Dec 1, 2023
6 of 14 checks passed
@d0cd d0cd deleted the feat/stubs-disassembler branch December 1, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d0cd d0cd d0cd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evan-schott @d0cd