Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Codegen for futures. #3097

Merged
merged 2 commits into from
Oct 27, 2023
Merged

[Fix] Codegen for futures. #3097

merged 2 commits into from
Oct 27, 2023

Conversation

d0cd
Copy link
Collaborator

@d0cd d0cd commented Oct 27, 2023

This PR fixes code generation to be compatible with futures.

Closes #3093.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #3097 (dc4668b) into testnet3 (f27531f) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##           testnet3    #3097      +/-   ##
============================================
- Coverage     78.87%   78.86%   -0.02%     
============================================
  Files           164      164              
  Lines          5516     5516              
  Branches       5516     5516              
============================================
- Hits           4351     4350       -1     
- Misses         1165     1166       +1     
Files Coverage Δ
...mpiler/passes/src/code_generation/visit_program.rs 76.19% <0.00%> (-0.74%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@acoglio acoglio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see nothing wrong, but I'm also too out of context about the details of this change to make a stronger assessment.

@d0cd d0cd merged commit 35a9133 into testnet3 Oct 27, 2023
7 of 8 checks passed
@d0cd d0cd deleted the fix/codegen-for-futures branch October 27, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] leo run Command Fails to Correctly generate Aleo Code from Leo code
2 participants