-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - Add GitHub Action to add contributors to README #3824
Feature - Add GitHub Action to add contributors to README #3824
Conversation
Codecov Report
@@ Coverage Diff @@
## testnet3 #3824 +/- ##
============================================
+ Coverage 79.24% 79.28% +0.04%
============================================
Files 172 172
Lines 5791 5798 +7
Branches 5791 5798 +7
============================================
+ Hits 4589 4597 +8
+ Misses 1202 1201 -1 see 4 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
This looks good. We worked on this next to each other in the office (fodder for others). Everything works as planned. There is a slight thing where the |
@collinc97, when you have a moment, we need to check if the GitHub Actions interface/bot(s) have the ability to approve pull requests which can be determined by whether the “Allow Github actions to create and approve pull requests” box is checked as @christianwooddell indicated which you can locate via If the box is checked, the bot should be ready and will work as expected. If not, please check that box. Should you like to test out @christianwooddell's bot, you can do so via his instance of it here. @christianwooddell has added you to his repo; you should see an invite via email shortly. |
@christianwwwwwwww @aharshbe pls check my message #4679 (comment) |
When a user submits a new issue, the bot first checks to see whether it is a request to be added as a contributor. If not, it quickly exits. The user will need to format the name of their request properly "Add XXXXX to contributors" in order for the action to run.
The GitHub Action ensures that:
main.leo
file)Then, the GitHub action:
Note: - For the GitHub action to be able to create PRs, we must ensure that the “Allow Github actions to create and approve pull requests” box is checked in the Leo repo under Settings -> Actions.
(cc @aharshbe )