rename of some function to add convert_

NAMESPACE

@@ -4,8 +4,12 @@ export("%>%")
 export(calculate_measures)
 export(check_year_format)
 export(convert_ca_to_lca)
+export(convert_date_to_numeric)
 export(convert_eng_gpprac_to_dummy)
 export(convert_fyyear_to_year)
+export(convert_hb_to_hbnames)
+export(convert_hscp_to_hscpnames)
+export(convert_numeric_to_date)
 export(convert_year_to_fyyear)
 export(create_day_episode_costs)
 export(create_demog_test_flags)
@@ -14,7 +18,6 @@ export(create_hb_test_flags)
 export(create_hscp_test_flags)
 export(create_monthly_beddays)
 export(create_monthly_costs)
-export(date_to_numeric)
 export(dd_period)
 export(end_fy)
 export(find_latest_file)
@@ -45,13 +48,10 @@ export(get_slf_postcode_path)
 export(get_source_extract_path)
 export(get_sparra_path)
 export(get_year_dir)
-export(hb_to_hbnames)
-export(hscp_to_hscpnames)
 export(is_missing)
 export(it_extract_ref)
 export(latest_update)
 export(midpoint_fy)
-export(numeric_to_date)
 export(phs_db_connection)
 export(previous_update)
 export(process_homelessness_extract)

R/convert_codes_to_name.R

@@ -7,8 +7,8 @@
 #'
 #' @examples
 #' hscp <- c("S37000001", "S37000002")
-#' hscp_to_hscpnames(hscp)
-hscp_to_hscpnames <- function(hscp) {
+#' convert_hscp_to_hscpnames(hscp)
+convert_hscp_to_hscpnames <- function(hscp) {
   hscpnames <- dplyr::case_when(
     hscp == "S37000001" ~ "Aberdeen City",
     hscp == "S37000002" ~ "Aberdeenshire",
@@ -55,8 +55,8 @@ hscp_to_hscpnames <- function(hscp) {
 #'
 #' @examples
 #' hb <- c("S08000015", "S08000016")
-#' hb_to_hbnames(hb)
-hb_to_hbnames <- function(hb) {
+#' convert_hb_to_hbnames(hb)
+convert_hb_to_hbnames <- function(hb) {
   hbnames <- dplyr::case_when(
     hb == "S08000015" ~ "Ayrshire and Arran",
     hb == "S08000016" ~ "Borders",

R/convert_date_types.R

@@ -6,8 +6,8 @@
 #' @export
 #'
 #' @examples
-#' date_to_numeric(as.Date("2021-03-31"))
-date_to_numeric <- function(date) {
+#' convert_date_to_numeric(as.Date("2021-03-31"))
+convert_date_to_numeric <- function(date) {
   lubridate::year(date) * 10000 +
     lubridate::month(date) * 100 +
     lubridate::day(date)
@@ -21,7 +21,7 @@ date_to_numeric <- function(date) {
 #' @export
 #'
 #' @examples
-#' numeric_to_date(c(20210101, 19993112))
-numeric_to_date <- function(numeric_date) {
+#' convert_numeric_to_date(c(20210101, 19993112))
+convert_numeric_to_date <- function(numeric_date) {
   as.Date(strptime(as.character(numeric_date), "%Y%m%d", tz = "UTC"))
 }

R/process_homelessness_extract.R

@@ -184,7 +184,7 @@ process_homelessness_extract <- function(year, write_to_disk = TRUE) {
   # Changes only required for SPSS ------------------------------------------
   final_data <- final_data %>%
     tidyr::replace_na(list(chi = "")) %>%
-    dplyr::mutate(dplyr::across(c(.data$record_keydate1, .data$record_keydate2), date_to_numeric)) %>%
+    dplyr::mutate(dplyr::across(c(.data$record_keydate1, .data$record_keydate2), convert_date_to_numeric)) %>%
     dplyr::arrange(.data$chi, .data$record_keydate1, .data$record_keydate2) %>%
     dplyr::mutate(
       postcode = stringr::str_pad(.data$postcode, width = 8, side = "right"),

tests/testthat/test-convert_codes_to_names.R

@@ -8,7 +8,7 @@ test_that("Can convert HSCP code to HSCP Name", {
   )
 
   expect_equal(
-    hscp_to_hscpnames(hscp),
+    convert_hscp_to_hscpnames(hscp),
     c(
       "Aberdeen City",
       "Glasgow City",
@@ -31,7 +31,7 @@ test_that("Can convert Health Board code to HB Name", {
   )
 
   expect_equal(
-    hb_to_hbnames(hb),
+    convert_hb_to_hbnames(hb),
     c(
       "Ayrshire and Arran",
       "Greater Glasgow and Clyde",

tests/testthat/test-convert_date_types.R

@@ -13,7 +13,7 @@ test_that("Can convert a date type to numeric", {
   ))
 
   expect_equal(
-    date_to_numeric(dates),
+    convert_date_to_numeric(dates),
     c(
       20170913,
       20180312,
@@ -44,7 +44,7 @@ test_that("Can convert a numeric 'date' to a proper date type", {
   )
 
   expect_equal(
-    numeric_to_date(numeric_dates),
+    convert_numeric_to_date(numeric_dates),
     as.Date(c(
       "2017/09/13",
       "2018/03/12",