Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong order for synopsis #90

Open
kuvakina opened this issue May 17, 2019 · 10 comments
Open

Wrong order for synopsis #90

kuvakina opened this issue May 17, 2019 · 10 comments

Comments

@kuvakina
Copy link
Collaborator

The order we see on Patient Summary page and on the issue page is different.

For OneLondon :
qq1.png
qq2.png

For Helm-RA :
qq3.png

@kuvakina
Copy link
Collaborator Author

@tony-shannon @PhilBarrett
on this task Bogdan approx need 2-3h

@tony-shannon
Copy link
Member

Bogdan to investigate this one please

@BogdanScherban
Copy link
Collaborator

@tony-shannon @DmitrySolyannik

I solve this issue in Showcase version.

I changed sort order in synopsis (to opposite):
Screenshot from 2019-05-28 15-34-08.png

And added default sort by dateCreated (opposite):
Screenshot from 2019-05-28 15-35-07.png

But I can't do this for plugins: Problems, Contacts, Mdt - because dateCreated fiels is absent in these plugins.

Screenshot from 2019-05-28 15-38-27.png

Screenshot from 2019-05-28 15-36-31.png

Screenshot from 2019-05-28 15-37-15.png

So, I suggest:

  1. Add dateCreated for all plugins, where it is absent;
  2. Save this changes to Showcase now. Later we will copy all common changes from Showcase to master-branch and merge it to NES, London and Helm.

@tony-shannon
Copy link
Member

ok thanks, need estimate of effort for those suggestions please

@BogdanScherban
Copy link
Collaborator

@tony-shannon

#1 - it needs @DmitrySolyannik estimation, because it is server-side issue.

#2 - I need in 2-3 h for this work:

  1. Create new branch based on Master
  2. Copy common changes from Showcase to Master
  3. Check, that everything works correctly
  4. Merge new branch to NES, London and Helm
  5. Check, that NES, London and Helm work correctly after merging and update them.
  6. Create PR

@BogdanScherban
Copy link
Collaborator

BogdanScherban commented May 31, 2019

@tony-shannon @PhilBarrett

I added required sorting at the client side (by dateCreated in opposite order).

But in some cases orders in synopsis and in table list aren't correspond.
For example, Medications

Screenshot from 2019-05-31 18-43-07.png

Screenshot from 2019-05-31 18-43-35.png:

You can see, that positions 1-3 are similar, but position 4 is different - 'Testing' in synopsis and 'Amoxicillin 500mg capsules' in table list.

The reason - 'Testing' and 'Amoxicillin 500mg capsules' have equal dateCreated - '08-06-2016'.
Screenshot from 2019-05-31 18-47-27.png

For this reason I suggest @DmitrySolyannik to add double sorting at the server side - by dateCreated (first) and by name (second). For both cases - for synopsis and for table list.

@tony-shannon
Copy link
Member

@DmitrySolyannik could you please discuss this with @robtweed to get a view from both of you on whether this is a client or server side issue please

@kuvakina
Copy link
Collaborator Author

kuvakina commented Jun 3, 2019

@tony-shannon Dima added his changes, @BogdanScherban could you please add changes on your side?

@kuvakina
Copy link
Collaborator Author

kuvakina commented Jun 3, 2019

@tony-shannon @PhilBarrett

As I understand it's working correct now, but the problem if that we have a lot issues in one heading with the same date. If we create issues for new patient and all issues won't be "today", we won't see the problem at all

For now, I'll move it to Review until we test it with new user

@PhilBarrett
Copy link
Member

@kuvakina can you confirm if this is ok to close now please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants