-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[READY] Reduce hex size #129
base: master
Are you sure you want to change the base?
Conversation
Why was gap fill originally enabled? |
We will need to add bootloader support for jumps in address |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Underlying issue necessitating gap fill should be fixed before this gets merged into master.
The link you sent in response to Gavin leads to a 404 for me. I would also like to see the original reasoning behind why we added the gap-fill flag as well.
What? Why is this? The bootloader is not able to jump and has to run sequentially? |
The base branch was changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This MR should not merge, for the same reason I mentioned earlier
Testing something out I still don't this
I was testing the CODEOWNERS file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test :•)
6 months ago gap fill was added to post build hex copying. This caused some hex inflation - up to 1GB....
This needed to be removed