[DRAFT] Sending CAN messages on peripherals 1 and 2 #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColexDev
reviewed
Nov 14, 2024
| periph = DEFAULT_PERIPHERAL_NODE | ||
|
|
||
| if 'can_peripheral_override' in msg: | ||
| periph = msg['can_peripheral_override'] |
There was a problem hiding this comment.
Indentation seems a bit too deep. I have no idea if python will get mad at this or not.
ColexDev
reviewed
Nov 14, 2024
| filter_bank_periph = {"CAN1": 0, "CAN2": 14} | ||
| filter_bank_max_periph = {"CAN1": 14, "CAN2": 27} | ||
|
|
||
| # these lines were default behavior, just moved into tuples above and symbols renamed |
There was a problem hiding this comment.
Small thing, if you are talking about lines 85-87, those are dictionaries and not tuples.
|
Looking good, we should probably do a bit more testing before merging though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.