Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number parsing #64

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Number parsing #64

wants to merge 11 commits into from

Conversation

ibizaman
Copy link
Collaborator

See #29

@Psycojoker
Copy link
Member

Sound great, thx! <3

But I've found another one that is not working :/

1.1e1j

Also the tokenizer is not ready for those new number, I'm going to fix this part.

@Psycojoker
Copy link
Member

Meh, this number system is quite a mess, it should be redo in another way I think :/ (I don't have ideas right now)

@Psycojoker
Copy link
Member

@ibizaman FYI, most of those notations brokes in baron.parse 485d051#diff-81fb1f6531d5e6901e587891a8b78f0bR399

@ibizaman
Copy link
Collaborator Author

FYI, most of those notations brokes in baron.parse 485d051#diff-81fb1f6531d5e6901e587891a8b78f0bR399

@Psycojoker what did you meant by that? It doesn't break the tests though.
Can we merge this PR?

@boxed
Copy link
Contributor

boxed commented Jul 26, 2017

Ping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibizaman @Psycojoker @boxed