Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generating import lib for PyPy when abi3 feature is enabled #4806

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Fix generating import lib for PyPy when abi3 feature is enabled #4806

merged 1 commit into from
Dec 18, 2024

Conversation

messense
Copy link
Member

@messense messense commented Dec 18, 2024 •
edited
Loading

We need to pass interpreter version to python3-dll-a for PyPy when abi3 feature is enabled, otherwise it will always throw Unsupported PyPy version.

See

@messense messense force-pushed the fix-generate-import-lib-for-pypy-with-abi3 branch from d3e6e67 to 798f66c Compare December 18, 2024 15:36
@messense messense force-pushed the fix-generate-import-lib-for-pypy-with-abi3 branch from 798f66c to 6f50e30 Compare December 18, 2024 15:39
@LilyFoote LilyFoote added this pull request to the merge queue Dec 18, 2024
Merged via the queue into PyO3:main with commit ea8c461 Dec 18, 2024
46 checks passed
@messense messense mentioned this pull request Dec 20, 2024
Closed
2 tasks
davidhewitt pushed a commit that referenced this pull request Jan 3, 2025
@messense @davidhewitt
Fix generating import lib for PyPy when abi3 feature is enabled (#4806)
bf9d5c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyFoote LilyFoote LilyFoote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@messense @LilyFoote