COPT update #383
Open
COPT update #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkstrp
reviewed
Nov 22, 2024
| @@ -109,8 +109,6 @@ | |||
| import coptpy | |||
|
|
|||
| with contextlib.suppress(coptpy.CoptError): | |||
There was a problem hiding this comment.
Suggested change
| with contextlib.suppress(coptpy.CoptError): | |
| available_solvers.append("copt") |
Please remove the check then as well
|
The issue is that we do use COPT. We have a floating license, but only a limited number of seats. Each time pypsa is imported it checks out the license even if you not doing solving a problem. Like building a snakemake workflow. |
|
Understood. You are right, we can just remove the check and the import check will be enough. If you resolve the comment, we can merge this. I don't have access to your fork and can't do it myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing this line of code stops COPT calling a floating license from a server in cases where COPT is not used to solve the problem.
Solver still solves as normal on my side after its removal.