[WIP] bootstrap5 + icons

[delijati]

Changes to work with bootstrap5 and bootstrap icons.

[delijati]

We should also remove support for python < 3.10!?

[stevepiercy]

When released, deform (and deformdemo) should support the currently supported versions of Python, which include 3.8-3.12, as well as the most recent PyPy that is available for testing in GitHub Actions.

• https://devguide.python.org/versions/
• https://www.pypy.org/download.html

[trollfot]

Should you need any help in getting this done, you can ping me.

[delijati]

Got also the functional tests working over here Pylons/deformdemo#124 ...

[delijati]

Here a preview (will turn if at some point) http://168.119.117.235:8523/

[goschtl]

@delijati @stevepiercy Any chance to cut a release with this changes? Is there anything i can help with?

cheers Christian

[delijati]

@delijati @stevepiercy Any chance to cut a release with this changes? Is there anything i can help with?

cheers Christian

It would be nice if someone has the time and can go through the bs4 roadmap list and cross off what we already have https://github.com/Pylons/deform/issues?q=is%3Aissue+is%3Aopen+label%3ABS4

[stevepiercy]

One minor housekeeping change.

[stevepiercy]

@delijati @goschtl for a release, I would do an alpha to start. That will allow us to get it out there for developer testing and cross off some of the issues tagged with bs4 with greater ease in subsequent alphas. I also set a milestone for 3.0 that needs some gardening.

Once I make an alpha release of deformdemo, we can adjust this PR to use that for the functional test suite.

[stevepiercy]

@delijati would you please do two housekeeping tasks before I merge?

• Sign https://github.com/Pylons/deformd/blob/main/CONTRIBUTORS.txt
• Update docs and readme with supported Python versions (3.8, 3.9, 3.10, 3.11, and 3.12).

Thank you!

[delijati]

@stevepiercy

* Sign https://github.com/Pylons/deformd/blob/main/CONTRIBUTORS.txt

I'm already in CONTRIBUTERS.txt (Josip Delić)

* Update docs and readme with supported Python versions (3.8, 3.9, 3.10, 3.11, and 3.12).

The only place i found was in index.rst. In the README.rst the versions are set by this link [1] and generated by the Trove classifiers in setup.py

[1] https://img.shields.io/pypi/pyversions/deform

[stevepiercy]

I did a more thorough review on this pass.

I think we can move stuff from deform/compat.py into core, now that we use Python 3 exclusively, and remove it.

[stevepiercy]

Thank you!

[stevepiercy]

Functional tests fail due to a recent change in Selenium 4.10.

https://github.com/Pylons/deform/actions/runs/6864014788/job/18665635754#step:7:457

TypeError: WebDriver.__init__() got an unexpected keyword argument 'desired_capabilities'

deform/setup.py

Lines 75 to 78 in f4da7df

	if PY37MIN:
	functional_testing_extras.extend(["selenium >= 4.0.0.b4"])
	else:
	functional_testing_extras.extend(["selenium >= 3.0, < 4.0"])

This should do the trick.

functional_testing_extras.extend(["selenium >= 4.0.0.b4, <4.10.0"])

In a later alpha, we can bump Selenium and update functional tests.

[goschtl]

@stevepiercy is there a roadmap or release-plan

where/how can we help to kick out a new release?

Christian

[stevepiercy]

@stevepiercy is there a roadmap or release-plan

#529 (comment)

where/how can we help to kick out a new release?

Get CI to pass. #529 (comment)

[delijati]

I opened a pull request to fix the last functional test https://github.com/Pylons/deformdemo/pull/125/files

[stevepiercy]

Now the tests run, but we have one test failure:

https://github.com/Pylons/deform/actions/runs/6868633228/job/18679624126?pr=529#step:7:403

I restarted the test run to see if that is a flaky test.

We also have a couple of deprecation warnings. A couple of them are in deform, with the rest in other packages. We could add the deform items to a future alpha release, and the others as issues in their repositories. I'll circle back on this PR and create issues as needed.

https://github.com/Pylons/deform/actions/runs/6868633228/job/18679624126?pr=529#step:7:405

[stevepiercy]

@delijati this test still fails.

https://github.com/Pylons/deform/actions/runs/6868633228/job/18683098188#step:7:350

Strange that it works in deformdemo, but not deform... 🤔

[stevepiercy]

Looks good. We need that one test in CI to pass.

[delijati]

Another PR in deformdemo Pylons/deformdemo#126

[stevepiercy]

Merged the deformdemo PR, restarted CI, let's see what happens. 🤞

[stevepiercy]

Same test still fails: https://github.com/Pylons/deform/actions/runs/6868633228/job/18697409622#step:7:351

[delijati]

|-( i hate selenium tests ... looking into it

[delijati]

@stevepiercy ok got it working locally https://github.com/Pylons/deformdemo/pull/127/files

[stevepiercy]

Restarted failed CI. 🤞

[delijati]

I will add this [1] to the tests if possible ... firefox does not scroll |-(

[1] https://stackoverflow.com/a/52045231/1154966

[delijati]

Added manual scroll to be in viewport of the button Pylons/deformdemo#128

[stevepiercy]

Success! I'll merge now, and cut a 3.0.0a release later this week. Thank you for your work on this!