-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prox approx part 3 #464
Prox approx part 3 #464
Conversation
bknueven
commented
Dec 2, 2024
- Re-implement cut manager based on tolerance
- Add cuts based on W
- Add safety cuts if W == 0 and xbar == xhat
- Don't bother if the variable is fixed
- Skip cut if it is outside the variable bounds
mpisppy/utils/sputils.py
Outdated
@@ -984,7 +984,8 @@ def nonant_cost_coeffs(s): | |||
if id(var) in s._mpisppy_data.varid_to_nonant_index: | |||
raise RuntimeError( | |||
"Found nonlinear variables in the objective function. " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change "Found nonlinear..." to "A call to nonant_cost_coefficient found nonlinear" (even though the user could figure that out from the stack trace, I don't want to give the impression that nonlinear is not OK in general")
To state the obvious: we could have both and that might even be a good idea (but does require even more work) |
Yes. I am confident this is an improvement over |