Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct ExtensiveForm docstring arg order and add missing parameter #465

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

maxfey
Copy link
Contributor

@maxfey maxfey commented Dec 2, 2024

Description

This pull request improves the documentation for the ExtensiveForm class by:

  1. Correcting the order of arguments in the docstring to match the __init__ method signature.
  2. Adding the missing all_nodenames argument to the docstring.

Changes Made

  • Updated the ExtensiveForm class docstring for consistency and completeness.

Rationale

The previous docstring was misleading due to:

  • A mismatch in the order of arguments.
  • The omission of the all_nodenames argument.

These changes enhance the clarity and usability of the documentation, making it easier for developers to understand and use the class.

Maximilian Fey and others added 2 commits December 2, 2024 21:39
- Update the docstring of the `ExtensiveForm` class to match the order of
  arguments in the `__init__` method signature.
- Add the missing `all_nodenames` argument to the docstring, using a
  description consistent with the parent class `SPBase` but styled to
  match `ExtensiveForm`.
@DLWoodruff DLWoodruff merged commit a4d6e8d into Pyomo:main Dec 2, 2024
17 checks passed
@DLWoodruff
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants