GDP: Don't transform known-to-be infeasible Disjuncts in multiple BigM #3314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
It's possible to discover that a Disjunct is infeasible in
gdp.mbigm
when calculating M values, since we solve each Disjunct for each disjunctive constraint in the same Disjunction. If we discovered that a Disjunct was infeasible during this process, we were deactivating it, but failing to remove it from the list of "active Disjuncts" that we are transforming. So nothing was mathematically wrong, but we were doing extra work transforming Disjuncts that couldn't possibly be selected. And, as a bonus, if you set baron as the solver for calculating M's, you could run into #3313, which is how we figured this out....Changes proposed in this PR:
active_disjuncts
list to aComponentSet
so that it's easy to remove things from it if they get deactivated.Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: