Resolve buffering issues in TeeStream
and capture_output
#3449
+442
−200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3084, fixes #3031, fixes #2845.
Summary/Motivation:
The HiGHS interface exposed some issues in the logic in
TeeStream
andcapture_output
where the two could end up fighting with each other. This PR should resolve all issues with console log management that we have been seeing with HiGHS.Changes proposed in this PR:
TeeStream
handle is propagated through tho the target output streamsTeeStream
tocapture_output
to prevent ending up with nestedTeeStream
instancesTeeStream
shoulddup
all target file descriptors so that subsequent context managers (likecapture_output
) don't commandeer them (causing a weird circular reference loop)capture_output
handles redirection (do not letredirect_fd
update thesys.stdout
/sys.stderr
streams)TeeStream
(andcapture_output
)capture_output
/TeeStream
for managing the console output.Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: