Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes 2 #1068

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Fixes 2 #1068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7970dc8
look for DONE in the bigger chunk of the response
Jul 29, 2024
c4455a9
Commented out Senko's last template until we get it fixed
Jul 29, 2024
ac7e3b6
Formatting fix
Jul 29, 2024
b0e6ea7
skip tests instead of commenting them out
LeonOstrez Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/agents/task_reviewer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ async def review_code_changes(self) -> AgentResponse:
)
llm_response: str = await llm(convo, temperature=0.7)

if "done" in llm_response.strip().lower()[-7:]:
if "done" in llm_response.strip().lower()[-20:]:
return AgentResponse.done(self)
else:
return AgentResponse.task_review_feedback(self, llm_response)
12 changes: 7 additions & 5 deletions core/templates/registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,24 @@

from core.log import get_logger

from .javascript_react import JavascriptReactProjectTemplate
from .node_express_mongoose import NodeExpressMongooseProjectTemplate
from .react_express import ReactExpressProjectTemplate

# from .react_express import ReactExpressProjectTemplate

log = get_logger(__name__)


class ProjectTemplateEnum(str, Enum):
"""Choices of available project templates."""

# JAVASCRIPT_REACT = JavascriptReactProjectTemplate.name
JAVASCRIPT_REACT = JavascriptReactProjectTemplate.name
NODE_EXPRESS_MONGOOSE = NodeExpressMongooseProjectTemplate.name
REACT_EXPRESS = ReactExpressProjectTemplate.name
# REACT_EXPRESS = ReactExpressProjectTemplate.name


PROJECT_TEMPLATES = {
# JavascriptReactProjectTemplate.name: JavascriptReactProjectTemplate,
JavascriptReactProjectTemplate.name: JavascriptReactProjectTemplate,
NodeExpressMongooseProjectTemplate.name: NodeExpressMongooseProjectTemplate,
ReactExpressProjectTemplate.name: ReactExpressProjectTemplate,
# ReactExpressProjectTemplate.name: ReactExpressProjectTemplate,
}
2 changes: 2 additions & 0 deletions tests/templates/test_templates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from core.templates.registry import PROJECT_TEMPLATES


@pytest.mark.skip
@pytest.mark.asyncio
@patch("core.state.state_manager.get_config")
async def test_render_react_express_sql(mock_get_config, testmanager):
Expand All @@ -30,6 +31,7 @@ async def test_render_react_express_sql(mock_get_config, testmanager):
assert "api/models/user.js" not in files


@pytest.mark.skip
@pytest.mark.asyncio
@patch("core.state.state_manager.get_config")
async def test_render_react_express_nosql(mock_get_config, testmanager):
Expand Down
Loading