2024 10 02 addcheck mandatory fk owner fk_operator fk_dataowner fk_provider fix missing references #163

sjib · 2024-10-03T14:24:04Z

Adds additional checks for references

fk_owner (only the ones that are MANDATORY)
fk_operator (only the ones that are MANDATORY)
fk_dataowner (all, as preparation for beeing MANDATORY in VSA-DSS / SIA405 Abwasser 2020.xx)
fk_provider (all, as preparation for beeing MANDATORY in VSA-DSS / SIA405 Abwasser 2020.xx)

Export will not be cancelled if fk_dataowner and fk_provider are missing, as we will get errors anyway (updated 4.10.2024)

for more information, see https://pre-commit.ci

…ttps://github.com/QGEP/qgepqwat2ili into 2024-10-02-addcheck_mandatory_fk_owner_fk_provider

for more information, see https://pre-commit.ci

…ttps://github.com/QGEP/qgepqwat2ili into 2024-10-02-addcheck_mandatory_fk_owner_fk_provider

for more information, see https://pre-commit.ci

…ttps://github.com/QGEP/qgepqwat2ili into 2024-10-02-addcheck_mandatory_fk_owner_fk_provider

sjib · 2024-10-03T14:53:29Z

@ponceta Here my improvements. Does this fit your needs? And support the migration process?

sjib · 2024-10-03T15:00:55Z

Should support and solve QGEP/QGEP#871

sjib · 2024-10-03T15:11:05Z


19s
Run python -m unittest qgepqwat2ili.tests.test_$SUITE
  python -m unittest qgepqwat2ili.tests.test_$SUITE
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.8.18/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.8.18/x64/lib
    SUITE: qgep
    QGEPQWAT2ILI_TESTDB_IMAGE: postgis/postgis:12-3.0
    PGHOST: 127.0.0.1
    PGPORT: 5432
    PGDATABASE: qgep_prod
    PGUSER: postgres
    PGPASS: postgres
Get:1 http://security.debian.org/debian-security buster/updates InRelease [34.8 kB]
Get:2 http://deb.debian.org/debian buster InRelease [122 kB]
Get:3 http://deb.debian.org/debian buster-updates InRelease [56.6 kB]
Get:4 http://security.debian.org/debian-security buster/updates/main amd64 Packages [610 kB]
Get:5 http://deb.debian.org/debian buster/main amd64 Packages [7,909 kB]
Ign:6 http://apt.postgresql.org/pub/repos/apt buster-pgdg InRelease
Get:7 http://deb.debian.org/debian buster-updates/main amd64 Packages [8,788 B]
Err:8 http://apt.postgresql.org/pub/repos/apt buster-pgdg Release
  404  Not Found [IP: 217.196.149.55 80]
Reading package lists...

I don't know why postgis 12-3.0 test are failing

sjib · 2024-10-04T09:18:01Z

TypeError: 'bool' object is not callable 
Traceback (most recent call last):
  File "C:\Users/Stefan/AppData/Roaming/QGIS/QGIS3\profiles\testing163neu2/python/plugins\qgepplugin\qgepqwat2ili\qgepqwat2ili\gui\__init__.py", line 490, in action_do_export
    check_fk_owner_null = check_fk_owner_null()
                          ^^^^^^^^^^^^^^^^^^^^^
TypeError: 'bool' object is not callable

for more information, see https://pre-commit.ci

…ttps://github.com/QGEP/qgepqwat2ili into 2024-10-02-addcheck_mandatory_fk_owner_fk_provider

is not a count but select statement - therefore check for none

…ttps://github.com/QGEP/qgepqwat2ili into 2024-10-02-addcheck_mandatory_fk_owner_fk_provider

for more information, see https://pre-commit.ci

…er etc. - rewrite query

…ttps://github.com/QGEP/qgepqwat2ili into 2024-10-02-addcheck_mandatory_fk_owner_fk_provider

for more information, see https://pre-commit.ci

sjib · 2024-10-04T21:48:04Z

should solve also QGEP/QGEP#872

for more information, see https://pre-commit.ci

…ttps://github.com/QGEP/qgepqwat2ili into 2024-10-02-addcheck_mandatory_fk_owner_fk_provider

sjib · 2024-10-10T13:13:36Z

Testing export:

SIA405 Abwasser ok
VSA-DSS 2015 ok
VSA-KEK 2019 not ok - Model VSA_KEK_2019_LV95 requires column T_basket

2024-10-10T11:43:04        qgepplugin.qgepqwat2ili.qgepqwat2ili.utils:EXECUTING: "C:\Program Files\Eclipse Foundation\jre-11.0.12.7-hotspot\bin\java" -jar "C:\Users\Stefan\AppData\Roaming\QGIS\QGIS3\profiles\testing163neu2\python\plugins\QgisModelBaker\libs\modelbaker\iliwrapper\bin\ili2pg-5.1.0\ili2pg-5.1.0.jar" --schemaimport --dbhost "localhost" --dbport "5433" --dbusr "postgres" --dbpwd "sjib" --dbdatabase "qgep_plugin163_dm162neu2" --dbschema pg2ili_abwasser --setupPgExt --createGeomIdx --createFk --createFkIdx --createTidCol --importTid --noSmartMapping --defaultSrsCode 2056 --log "C:/Daten/QGEP/testing163neu2/20241010_qgep-export.xtf.241010114304.ili2pg-schemaimport.log" --nameLang de C:\Users/Stefan/AppData/Roaming/QGIS/QGIS3\profiles\testing163neu2/python/plugins\qgepplugin\qgepqwat2ili\qgepqwat2ili\ili\VSA_KEK_2019_2_d_LV95-20210120.ili
2024-10-10T11:43:07        qgepplugin.qgepqwat2ili.qgepqwat2ili.utils:Info: dburl 
             Info: dbusr 
             Info: ili2pg-5.1.0-58fc980cc6639b2c16a3cff8a0fa19ef1484b11c 
             Info: ili2c-5.4.0-91aba866d30f916433a776ce49d0b2e6d2883964 
             Info: iox-ili-1.22.0-0b7b9eae24ccb50d1b938cffdf2062748500c0c0 
             Info: java.version 11.0.12 
             Info: user.name 
             Info: maxMemory 4147200 KB 
             Info: currentTime 2024-10-10 11:43:05 
             Info: dbschema 
             Info: dburl 
             Info: dbusr 
             Info: databaseProduct 
             Info: databaseVersion 
             Info: driverName 
             Info: driverVersion 
             Info: postGISVersion 
             Info: max active DB statements 
             Info: compile models... 
             Info: lookup model 2.3 in repository 
             Info: lookup model 2.3 in repository 
             Info: lookup model 2.3 in repository 
             Info: lookup model 2.3 in repository 
             Info: ilifile 
             Info: ilifile 
             Info: ilifile 
             Info: ilifile 
             Info: ilifile 
             Model VSA_KEK_2019_LV95 requires column T_basket

sjib · 2024-10-10T13:15:48Z

@ponceta Model VSA_KEK_2019_LV95 requires column T_basket - How far is the work of opengis on this?
#160
Will this replace your try? #138

…ttps://github.com/QGEP/qgepqwat2ili into 2024-10-02-addcheck_mandatory_fk_owner_fk_provider

sjib · 2024-10-10T13:20:23Z

qgepqwat2ili/utils/ili2db.py:472:9: F541 f-string is missing placeholders

sjib · 2024-12-20T20:49:11Z

Should support and solve QGEP/QGEP#889

sjib · 2024-12-20T20:56:08Z

Should also support and solve QGEP/QGEP#876

sjib added 2 commits October 3, 2024 16:21

add new check def check_fk_owner_null()

715e199

def check_fk_operator_null

43adf7d

sjib self-assigned this Oct 3, 2024

[pre-commit.ci] auto fixes from pre-commit.com hooks

c6f5220

for more information, see https://pre-commit.ci

sjib added enhancement New feature or request Sustainability labels Oct 3, 2024

sjib and others added 8 commits October 3, 2024 16:28

check_fk_dataowner

037eaba

Merge branch '2024-10-02-addcheck_mandatory_fk_owner_fk_provider' of h…

4432a46

…ttps://github.com/QGEP/qgepqwat2ili into 2024-10-02-addcheck_mandatory_fk_owner_fk_provider

check_fk_provider

8702b5c

[pre-commit.ci] auto fixes from pre-commit.com hooks

fe4fbbf

for more information, see https://pre-commit.ci

add check_fk_owner_null

273ff72

Merge branch '2024-10-02-addcheck_mandatory_fk_owner_fk_provider' of h…

259a230

…ttps://github.com/QGEP/qgepqwat2ili into 2024-10-02-addcheck_mandatory_fk_owner_fk_provider

add check_fk_operator_null

094bdb4

add check_fk_dataowner_null

e7dfea9

sjib changed the title ~~2024 10 02 addcheck mandatory fk owner fk provider~~ 2024 10 02 addcheck mandatory fk owner fk_operator fk_dataowner fk_provider Oct 3, 2024

pre-commit-ci bot and others added 3 commits October 3, 2024 14:48

[pre-commit.ci] auto fixes from pre-commit.com hooks

ac9bc33

for more information, see https://pre-commit.ci

correction

a35dd9a

Merge branch '2024-10-02-addcheck_mandatory_fk_owner_fk_provider' of h…

399fef5

…ttps://github.com/QGEP/qgepqwat2ili into 2024-10-02-addcheck_mandatory_fk_owner_fk_provider

sjib requested a review from ponceta October 3, 2024 14:50

add if flag_test:

47c728b

ponceta closed this Oct 4, 2024

ponceta reopened this Oct 4, 2024

sjib and others added 4 commits October 4, 2024 11:27

add new functions

f1670be

[pre-commit.ci] auto fixes from pre-commit.com hooks

284c8dd

for more information, see https://pre-commit.ci

take out time.sleep

6b25d3f

Merge branch '2024-10-02-addcheck_mandatory_fk_owner_fk_provider' of h…

71559b9

…ttps://github.com/QGEP/qgepqwat2ili into 2024-10-02-addcheck_mandatory_fk_owner_fk_provider

sjib and others added 7 commits October 4, 2024 21:55

adapt get_wwtp_structure_ids():

bb69b21

is not a count but select statement - therefore check for none

Merge branch '2024-10-02-addcheck_mandatory_fk_owner_fk_provider' of h…

b509c7a

…ttps://github.com/QGEP/qgepqwat2ili into 2024-10-02-addcheck_mandatory_fk_owner_fk_provider

change variable name

1567caf

[pre-commit.ci] auto fixes from pre-commit.com hooks

790c79c

for more information, see https://pre-commit.ci

rename wwtp_structure_id_list to wastewater_structure_id_sia405abwass…

28a27fe

…er etc. - rewrite query

Merge branch '2024-10-02-addcheck_mandatory_fk_owner_fk_provider' of h…

5e742a5

…ttps://github.com/QGEP/qgepqwat2ili into 2024-10-02-addcheck_mandatory_fk_owner_fk_provider

[pre-commit.ci] auto fixes from pre-commit.com hooks

c621112

for more information, see https://pre-commit.ci

sjib changed the title ~~2024 10 02 addcheck mandatory fk owner fk_operator fk_dataowner fk_provider~~ 2024 10 02 addcheck mandatory fk owner fk_operator fk_dataowner fk_provider fix missing references Oct 4, 2024

sjib mentioned this pull request Oct 4, 2024

Errors Export Interlis with QGEP 1.6.3 QGEP/QGEP#872

Closed

sjib and others added 6 commits October 10, 2024 11:19

update qgep export.py

9ec46e7

add empty lines

924bc15

update qgepdss export.py

071b65d

[pre-commit.ci] auto fixes from pre-commit.com hooks

b5a7677

for more information, see https://pre-commit.ci

adapte logger warning val

56e1af4

Merge branch '2024-10-02-addcheck_mandatory_fk_owner_fk_provider' of h…

9b70690

…ttps://github.com/QGEP/qgepqwat2ili into 2024-10-02-addcheck_mandatory_fk_owner_fk_provider

ponceta closed this Oct 10, 2024

ponceta reopened this Oct 10, 2024

ponceta and others added 3 commits October 10, 2024 15:19

fix flake8

9c2d502

no f-string, as there are no placeholders

a29eb3f

Merge branch '2024-10-02-addcheck_mandatory_fk_owner_fk_provider' of h…

5a11b83

…ttps://github.com/QGEP/qgepqwat2ili into 2024-10-02-addcheck_mandatory_fk_owner_fk_provider

ponceta approved these changes Oct 10, 2024

View reviewed changes

ponceta merged commit bb551e2 into master Oct 10, 2024
5 checks passed

ponceta deleted the 2024-10-02-addcheck_mandatory_fk_owner_fk_provider branch October 10, 2024 13:37

ponceta mentioned this pull request Oct 18, 2024

Upgrade qgep used docker image #171

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2024 10 02 addcheck mandatory fk owner fk_operator fk_dataowner fk_provider fix missing references #163

2024 10 02 addcheck mandatory fk owner fk_operator fk_dataowner fk_provider fix missing references #163

sjib commented Oct 3, 2024 •

edited

Loading

sjib commented Oct 3, 2024

sjib commented Oct 3, 2024

sjib commented Oct 3, 2024

sjib commented Oct 4, 2024

sjib commented Oct 4, 2024

sjib commented Oct 10, 2024

sjib commented Oct 10, 2024

sjib commented Oct 10, 2024

sjib commented Dec 20, 2024

sjib commented Dec 20, 2024

2024 10 02 addcheck mandatory fk owner fk_operator fk_dataowner fk_provider fix missing references #163

2024 10 02 addcheck mandatory fk owner fk_operator fk_dataowner fk_provider fix missing references #163

Conversation

sjib commented Oct 3, 2024 • edited Loading

sjib commented Oct 3, 2024

sjib commented Oct 3, 2024

sjib commented Oct 3, 2024

sjib commented Oct 4, 2024

sjib commented Oct 4, 2024

sjib commented Oct 10, 2024

sjib commented Oct 10, 2024

sjib commented Oct 10, 2024

sjib commented Dec 20, 2024

sjib commented Dec 20, 2024

sjib commented Oct 3, 2024 •

edited

Loading