fix: Resolve an error when giving keys without ID #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attempting to give keys to another player without an ID an error was given. It had to do with closestDistance being nil.
Added a new config option "distanceToHandKeys = 3" so players can adjust the range at which to hand keys over.
Manason
approved these changes
Dec 6, 2024
mafewtm
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When attempting to hand keys to someone standing next to you without using an ID an error would be generated:
The error was from a nil value. I added a config setting, got rid of the nil value error, and added in user notifications.
Before: https://medal.tv/games/gta-v/clips/je2GVr3kBS0OLfjWB?invite=cr-MSxsZ3csMTk1NzEzNDc0LA
After: https://medal.tv/games/gta-v/clips/je2JXUH9ehD7sHQ5P?invite=cr-MSxPYUMsMTk1NzEzNDc0LA
Checklist