Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to fxmanifest and config #23

Merged
merged 5 commits into from
Nov 17, 2023
Merged

Conversation

adweex
Copy link
Contributor

@adweex adweex commented Nov 5, 2023

Description

Refactoring config, also adding some extra chances based on vehicle class. This is one part of the rewriting

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My code fits the style guidelines.
  • My PR fits the contribution guidelines.

config.lua Outdated Show resolved Hide resolved
config.lua Outdated Show resolved Hide resolved
config.lua Outdated Show resolved Hide resolved
config.lua Outdated Show resolved Hide resolved
config.lua Outdated Show resolved Hide resolved
config.lua Outdated Show resolved Hide resolved
config.lua Show resolved Hide resolved
@adweex adweex requested a review from Manason November 5, 2023 21:34
@Manason
Copy link
Member

Manason commented Nov 11, 2023

You may want to change references to config as code as part of this PR as well.

@adweex
Copy link
Contributor Author

adweex commented Nov 11, 2023

You may want to change references to config as code as part of this PR as well.

Done

@adweex adweex requested a review from Manason November 11, 2023 12:02
config.lua Show resolved Hide resolved
@Manason Manason merged commit a79a0bd into Qbox-project:main Nov 17, 2023
2 checks passed
@Manason
Copy link
Member

Manason commented Nov 17, 2023

Consider further modifications to config similar to qbx_core:

  • Split into client, server, and shared files
  • Make into modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants